linux-kernel - Re: [PATCH v2 06/11] dt-bindings: display: panel: Describe Samsung SOFEF03-M DDIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aVGvtJ0NekR1ch-k@SoMainline.org>
Date: Sun, 28 Dec 2025 23:49:13 +0100
From: Marijn Suijten <marijn.suijten@...ainline.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, 
	Sam Ravnborg <sam@...nborg.org>, David Airlie <airlied@...il.com>, 
	Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
	Conor Dooley <conor+dt@...nel.org>, Andy Gross <agross@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, Jessica Zhang <jesszhan0024@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, Simona Vetter <simona@...ll.ch>, 
	Casey Connolly <casey.connolly@...aro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Simona Vetter <simona.vetter@...ll.ch>, 
	~postmarketos/upstreaming@...ts.sr.ht, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>, Martin Botka <martin.botka@...ainline.org>, 
	Jami Kettunen <jami.kettunen@...ainline.org>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	Abhinav Kumar <quic_abhinavk@...cinc.com>, Kuogee Hsieh <quic_khsieh@...cinc.com>, 
	Jessica Zhang <quic_jesszhan@...cinc.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
	Konrad Dybcio <konradybcio@...nel.org>, Dmitry Baryshkov <lumag@...nel.org>
Subject: Re: [PATCH v2 06/11] dt-bindings: display: panel: Describe Samsung
 SOFEF03-M DDIC

On 2025-12-22 09:36:23, Krzysztof Kozlowski wrote:
> On 22/12/2025 09:33, Krzysztof Kozlowski wrote:
> >> +  - |
> >> +    #include <dt-bindings/gpio/gpio.h>
> >> +
> >> +    dsi {
> >> +        #address-cells = <1>;
> >> +        #size-cells = <0>;
> >> +        panel@0 {
> >> +            compatible = "samsung,sofef03-m-amb609vp01";
> >> +            reg = <0>;
> >> +
> >> +            reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
> >> +
> >> +            vci-supply = <&vreg_l11c_3p0>;
> >> +            vddio-supply = <&vreg_l14a_1p8>;
> >> +
> >> +            port {
> > 
> > Not tested :/
> 
> Ah no, this one is correct. It's the other patch with similar compatible
> which was not tested.

I think you mean:

	.output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$'
		from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml
	.output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'port' is a required property
		from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml

Which looks to be fixed by including panel-common-dual.yaml and changing `port`
to `ports` in the properties and required table?  At least the errors are gone,
just asking if that is acceptable.

Then:

	.output/Documentation/devicetree/bindings/display/panel/samsung,sofef01-m.example.dtb: panel@0 (samsung,sofef01-m-amb609tc01): 'vci-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
		from schema $id: http://devicetree.org/schemas/display/panel/samsung,sofef01-m.yaml

Which I do not immediately understand how to resolve.  I'd believe there's a
problem with the conditional inclusion of this vci-supply property based on the
compatible name, but do not see where the problem lies as other dt-bindings seem
to write it this way as well.  Can you point this out to me?

Alternatively I'll drop the example with vci-supply, but this'll return when
said panel is committed to DTS.

Lastly checkpatch complains that the "lgd" prefix isn't a valid vendor.  Should
I add "LG Display" to the list or rename it to "lg,"?

> Actually two others were not tested. We are not a testing service - it
> is your task.

That is not very kind; sometimes things might slip through and it's nice if CI
catches them at a last resort.

- Marijn