linux-kernel - Re: [PATCH v5 1/2] i2c: spacemit: replace i2c_xfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86E3DC2399D2C68D+aVEG8iEgR4iSn5Vw@troy-wujie14pro-arch>
Date: Sun, 28 Dec 2025 18:31:14 +0800
From: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
To: Andi Shyti <andi.shyti@...nel.org>,
	Troy Mitchell <troy.mitchell@...ux.spacemit.com>
Cc: Yixun Lan <dlan@...too.org>, Alex Elder <elder@...cstar.com>,
	Aurelien Jarno <aurelien@...el32.net>,
	Michael Opdenacker <michael.opdenacker@...tcommit.com>,
	Troy Mitchell <troymitchell988@...il.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev
Subject: Re: [PATCH v5 1/2] i2c: spacemit: replace i2c_xfer_msg()

On Sat, Dec 27, 2025 at 08:45:31PM +0100, Andi Shyti wrote:
> Hi Troy,
> 
> On Fri, Dec 26, 2025 at 11:31:10AM +0800, Troy Mitchell wrote:
> > The upcoming PIO support requires a wait_pio_xfer() helper, which is
> > invoked from xfer_msg().
> > 
> > Since wait_pio_xfer() depends on err_check(), move the definition of
> > xfer_msg() after err_check() to avoid a forward declaration of
> > err_check().
> 
> on the subject, this is clearly an i2c_xfer_msg move, not a
> replace, right?
Yes.
> 
> (if no v6 is coming, there is no need to resend for this, it can
> be fixed before merging).
Thanks! 

                                  - Troy