linux-kernel - Re: [PATCH v4 7/7] ARM: dts: rockchip: rk3506: Add pinctrl and rmio dtsi for rk3506

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebb720f6-4756-437f-a71a-d94f45d732e8@kernel.org>
Date: Sun, 28 Dec 2025 11:37:35 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ye Zhang <ye.zhang@...k-chips.com>,
 Linus Walleij <linus.walleij@...aro.org>, Heiko Stuebner <heiko@...ech.de>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 tao.huang@...k-chips.com
Subject: Re: [PATCH v4 7/7] ARM: dts: rockchip: rk3506: Add pinctrl and rmio
 dtsi for rk3506

On 27/12/2025 12:49, Ye Zhang wrote:
> +		/omit-if-no-ref/
> +		rm_io28_touch_key_in6: rm-io28-touch-key-in6 {
> +			rockchip,pins =
> +				<1 RK_PC3 7 &pcfg_pull_none>;
> +			rockchip,rmio-pins =
> +				<0 28 49>;
> +		};
> +
> +		/omit-if-no-ref/
> +		rm_io28_touch_key_in7: rm-io28-touch-key-in7 {
> +			rockchip,pins =
> +				<1 RK_PC3 7 &pcfg_pull_none>;
> +			rockchip,rmio-pins =
> +				<0 28 50>;
> +		};
> +
> +		/omit-if-no-ref/
> +		rm_io28_sai0_mclk: rm-io28-sai0-mclk {
> +			rockchip,pins =
> +				<1 RK_PC3 7 &pcfg_pull_none>;
> +			rockchip,rmio-pins =
> +				<0 28 51>;
> +		};
> +
> +		/omit-if-no-ref/
> +		rm_io28_sai0_sclk: rm-io28-sai0-sclk {
> +			rockchip,pins =
> +				<1 RK_PC3 7 &pcfg_pull_none>;
> +			rockchip,rmio-pins =
> +				<0 28 52>;
> +		};
> +
> +		/omit-if-no-ref/
> +		rm_io28_sai0_lrck: rm-io28-sai0-lrck {
> +			rockchip,pins =
> +				<1 RK_PC3 7 &pcfg_pull_none>;
> +			rockchip,rmio-pins =
> +				<0 28 53>;
> +		};
> +
> +		/omit-if-no-ref/
> +		rm_io28_sai0_sdi0: rm-io28-sai0-sdi0 {
> +			rockchip,pins =
> +				<1 RK_PC3 7 &pcfg_pull_none>;
> +			rockchip,rmio-pins =
> +				<0 28 54>;
> +		};

Why are you defining all pins? This is wrong, your driver has to do it,
not DTS. All these definitions when not used are just pointless.


Best regards,
Krzysztof