linux-kernel - Re: [PATCH 5/8] regulator: core: remove dead code in regulator_resolve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1baa0a0e89385b7ca8f56f65efd79a42f3eeaa74.camel@linaro.org>
Date: Mon, 29 Dec 2025 06:43:51 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Javier Martinez Canillas	
 <javier@....samsung.com>, Jon Hunter <jonathanh@...dia.com>, Dmitry
 Baryshkov	 <lumag@...nel.org>, Oleksij Rempel <o.rempel@...gutronix.de>,
 Peter Griffin	 <peter.griffin@...aro.org>, Tudor Ambarus
 <tudor.ambarus@...aro.org>, Will McVicker <willmcvicker@...gle.com>, Juan
 Yescas <jyescas@...gle.com>, kernel-team@...roid.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/8] regulator: core: remove dead code in
 regulator_resolve_supply()

Hi Mark,

On Sat, 2025-12-27 at 20:01 +0000, Mark Brown wrote:
> On Sat, Dec 27, 2025 at 12:17:49PM +0000, André Draszik wrote:
> 
> > No functional change intended.
> 
> > Fixes: 98e48cd9283d ("regulator: core: resolve supply for boot-on/always-on regulators")
> 
> If this is just a cleanup then clearly it's not fixing a bug.  Please
> don't throw Fixes tags on random commits that don't actually fix bugs,
> it just makes noise for people who are looking for actual fixes.

I added it to highlight that the dead code removal should have been
part of that commit, but left out CC:stable for the reason that this
commit is not strictly required. Especially the now incorrect comment
in the code was a bit confusing since that commit, and I wanted to make
it easier for future reader of that code, no matter which kernel version
somebody else might be looking at.

Anyway, will drop in next version.

Cheers,
Andre'