| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <c60288a5-189d-4761-99eb-4681effe1252@oss.qualcomm.com>
Date: Mon, 29 Dec 2025 09:10:14 +0800
From: Jie Gan <jie.gan@....qualcomm.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, oe-kbuild@...ts.linux.dev,
Suzuki K Poulose <suzuki.poulose@....com>,
Mike Leach
<mike.leach@...aro.org>,
James Clark <james.clark@...aro.org>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Tingwei Zhang <tingwei.zhang@....qualcomm.com>,
Mao Jinlong <jinlong.mao@....qualcomm.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev, coresight@...ts.linaro.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v9 2/8] coresight: tmc: add create/clean functions for
etr_buf_list
On 12/26/2025 9:17 PM, Dan Carpenter wrote:
> Hi Jie,
>
> kernel test robot noticed the following build warnings:
>
> url: https://github.com/intel-lab-lkp/linux/commits/Jie-Gan/coresight-core-Refactoring-ctcu_get_active_port-and-make-it-generic/20251224-171604
> base: 47b7b5e32bb7264b51b89186043e1ada4090b558
> patch link: https://lore.kernel.org/r/20251224-enable-byte-cntr-for-ctcu-v9-2-886c4496fed4%40oss.qualcomm.com
> patch subject: [PATCH v9 2/8] coresight: tmc: add create/clean functions for etr_buf_list
> config: arm-randconfig-r073-20251225 (https://download.01.org/0day-ci/archive/20251225/202512251923.GDSbVal1-lkp@intel.com/config)
> compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 4ef602d446057dabf5f61fb221669ecbeda49279)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> | Closes: https://lore.kernel.org/r/202512251923.GDSbVal1-lkp@intel.com/
>
> smatch warnings:
> drivers/hwtracing/coresight/coresight-tmc-etr.c:1992 tmc_create_etr_buf_list() warn: passing freed memory 'new_node' (line 1991)
> drivers/hwtracing/coresight/coresight-tmc-etr.c:1992 tmc_create_etr_buf_list() warn: passing zero to 'PTR_ERR'
>
> vim +/new_node +1992 drivers/hwtracing/coresight/coresight-tmc-etr.c
>
> 34af91eeb7e78e Jie Gan 2025-12-24 1959 int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int num_nodes)
> 34af91eeb7e78e Jie Gan 2025-12-24 1960 {
> 34af91eeb7e78e Jie Gan 2025-12-24 1961 struct etr_buf_node *new_node;
> 34af91eeb7e78e Jie Gan 2025-12-24 1962 struct etr_buf *sysfs_buf;
> 34af91eeb7e78e Jie Gan 2025-12-24 1963 int i = 0, ret = 0;
> 34af91eeb7e78e Jie Gan 2025-12-24 1964
> 34af91eeb7e78e Jie Gan 2025-12-24 1965 /* We dont need a list if there is only one node */
> 34af91eeb7e78e Jie Gan 2025-12-24 1966 if (num_nodes < 2)
> 34af91eeb7e78e Jie Gan 2025-12-24 1967 return -EINVAL;
> 34af91eeb7e78e Jie Gan 2025-12-24 1968
> 34af91eeb7e78e Jie Gan 2025-12-24 1969 /* We expect that sysfs_buf in drvdata has already been allocated. */
> 34af91eeb7e78e Jie Gan 2025-12-24 1970 if (drvdata->sysfs_buf) {
> 34af91eeb7e78e Jie Gan 2025-12-24 1971 /* Directly insert the allocated sysfs_buf into the list first */
> 34af91eeb7e78e Jie Gan 2025-12-24 1972 new_node = kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL);
> 34af91eeb7e78e Jie Gan 2025-12-24 1973 if (IS_ERR(new_node))
> 34af91eeb7e78e Jie Gan 2025-12-24 1974 return PTR_ERR(new_node);
> 34af91eeb7e78e Jie Gan 2025-12-24 1975
> 34af91eeb7e78e Jie Gan 2025-12-24 1976 new_node->sysfs_buf = drvdata->sysfs_buf;
> 34af91eeb7e78e Jie Gan 2025-12-24 1977 new_node->is_free = false;
> 34af91eeb7e78e Jie Gan 2025-12-24 1978 list_add(&new_node->node, &drvdata->etr_buf_list);
> 34af91eeb7e78e Jie Gan 2025-12-24 1979 i++;
> 34af91eeb7e78e Jie Gan 2025-12-24 1980 }
> 34af91eeb7e78e Jie Gan 2025-12-24 1981
> 34af91eeb7e78e Jie Gan 2025-12-24 1982 while (i < num_nodes) {
> 34af91eeb7e78e Jie Gan 2025-12-24 1983 new_node = kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL);
> 34af91eeb7e78e Jie Gan 2025-12-24 1984 if (IS_ERR(new_node)) {
> 34af91eeb7e78e Jie Gan 2025-12-24 1985 ret = PTR_ERR(new_node);
> 34af91eeb7e78e Jie Gan 2025-12-24 1986 break;
> 34af91eeb7e78e Jie Gan 2025-12-24 1987 }
> 34af91eeb7e78e Jie Gan 2025-12-24 1988
> 34af91eeb7e78e Jie Gan 2025-12-24 1989 sysfs_buf = tmc_alloc_etr_buf(drvdata, drvdata->size, 0, cpu_to_node(0), NULL);
> 34af91eeb7e78e Jie Gan 2025-12-24 1990 if (IS_ERR(sysfs_buf)) {
> 34af91eeb7e78e Jie Gan 2025-12-24 @1991 kfree(new_node);
> 34af91eeb7e78e Jie Gan 2025-12-24 @1992 ret = PTR_ERR(new_node);
>
> s/new_node/sysfs_buf/
Thanks for reporting. Will fix it.
-Jie
>
> 34af91eeb7e78e Jie Gan 2025-12-24 1993 break;
> 34af91eeb7e78e Jie Gan 2025-12-24 1994 }
> 34af91eeb7e78e Jie Gan 2025-12-24 1995
> 34af91eeb7e78e Jie Gan 2025-12-24 1996 /* We dont have a available sysfs_buf in drvdata, setup one */
> 34af91eeb7e78e Jie Gan 2025-12-24 1997 if (!drvdata->sysfs_buf) {
> 34af91eeb7e78e Jie Gan 2025-12-24 1998 drvdata->sysfs_buf = sysfs_buf;
> 34af91eeb7e78e Jie Gan 2025-12-24 1999 new_node->is_free = false;
> 34af91eeb7e78e Jie Gan 2025-12-24 2000 } else
> 34af91eeb7e78e Jie Gan 2025-12-24 2001 new_node->is_free = true;
> 34af91eeb7e78e Jie Gan 2025-12-24 2002
> 34af91eeb7e78e Jie Gan 2025-12-24 2003 new_node->sysfs_buf = sysfs_buf;
> 34af91eeb7e78e Jie Gan 2025-12-24 2004 list_add(&new_node->node, &drvdata->etr_buf_list);
> 34af91eeb7e78e Jie Gan 2025-12-24 2005 i++;
> 34af91eeb7e78e Jie Gan 2025-12-24 2006 }
> 34af91eeb7e78e Jie Gan 2025-12-24 2007
> 34af91eeb7e78e Jie Gan 2025-12-24 2008 /* Clean the list if there is an error */
> 34af91eeb7e78e Jie Gan 2025-12-24 2009 if (ret)
> 34af91eeb7e78e Jie Gan 2025-12-24 2010 tmc_clean_etr_buf_list(drvdata);
> 34af91eeb7e78e Jie Gan 2025-12-24 2011
> 34af91eeb7e78e Jie Gan 2025-12-24 2012 return ret;
> 34af91eeb7e78e Jie Gan 2025-12-24 2013 }
>
Powered by blists - more mailing lists