linux-kernel - Re: [PATCH v5 3/3] i2c: spacemit: drop warning when clock-frequency property is absent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E42FFF2530F73556+aVHXeY6PlQt40uY1@kernel.org>
Date: Mon, 29 Dec 2025 09:20:57 +0800
From: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
To: Alex Elder <elder@...cstar.com>,
	Troy Mitchell <troy.mitchell@...ux.spacemit.com>,
	Andi Shyti <andi.shyti@...nel.org>, Yixun Lan <dlan@...too.org>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev
Subject: Re: [PATCH v5 3/3] i2c: spacemit: drop warning when clock-frequency
 property is absent

On Sun, Dec 28, 2025 at 06:56:38PM -0600, Alex Elder wrote:
> On 12/26/25 2:32 AM, Troy Mitchell wrote:
> > The clock-frequency property is optional according to the DT binding.
> > Do not emit a warning when the property is missing and fall back to the
> > default frequency instead.
> > 
> > Fixes: 5ea558473fa31 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> > Suggested-by: Alex Elder <elder@...cstar.com>
> > Signed-off-by: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
> 
> Any error reading the "clock-frequency" property will simply leave
> i2c->clock_freq alone.  This is good.
> 
> But the lines that follow this issue a warning if i2c->clock_freq
> is 0.  If it's optional, you should simply use a default value,
> and although you could state that rate with dev_info(), you should
> not warn about it.
Thanks! I get your point!

              - Troy