linux-kernel - Re: [PATCH v2] soc: mediatek: svs: Fix memory leak in svs_enable_debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d9b46ba-728e-459a-9d82-0f49e2fe08b9@web.de>
Date: Mon, 29 Dec 2025 09:19:19 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Jianhao Xu <jianhao.xu@....edu.cn>, Zilin Guan <zilin@....edu.cn>,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 Matthias Brugger <matthias.bgg@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v2] soc: mediatek: svs: Fix memory leak in
 svs_enable_debug_write()

…
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -789,7 +789,7 @@ static ssize_t svs_enable_debug_write(struct file *filp,
>  	struct svs_bank *svsb = file_inode(filp)->i_private;
>  	struct svs_platform *svsp = dev_get_drvdata(svsb->dev);
>  	int enabled, ret;
> -	char *buf = NULL;
> +	char *buf __free(kfree) = NULL;
>  
>  	if (count >= PAGE_SIZE)
>  		return -EINVAL;
…

You may reduce the scopes for involved local variables,
don't you?


See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n262

Regards,
Markus