linux-kernel - Re: [PATCH v4 7/7] ARM: dts: rockchip: rk3506: Add pinctrl and rmio dtsi for rk3506

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57d27a43-4c3a-415b-b633-3d52c9f96f5a@kernel.org>
Date: Mon, 29 Dec 2025 09:47:54 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: 张烨 <ye.zhang@...k-chips.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, Heiko Stuebner
 <heiko@...ech.de>, Bartosz Golaszewski <brgl@...ev.pl>,
 Rob Herring <robh@...nel.org>, krzk+dt <krzk+dt@...nel.org>,
 conor+dt <conor+dt@...nel.org>, linux-gpio <linux-gpio@...r.kernel.org>,
 devicetree <devicetree@...r.kernel.org>,
 linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
 linux-rockchip <linux-rockchip@...ts.infradead.org>,
 linux-kernel <linux-kernel@...r.kernel.org>,
 "tao.huang" <tao.huang@...k-chips.com>
Subject: Re: [PATCH v4 7/7] ARM: dts: rockchip: rk3506: Add pinctrl and rmio
 dtsi for rk3506

On 29/12/2025 08:25, 张烨 wrote:
> 在 2025/12/28 18:37, Krzysztof Kozlowski 写道:
> &gt; On 27/12/2025 12:49, Ye Zhang wrote:
> &gt;&gt; +		/omit-if-no-ref/
> &gt;&gt; +		rm_io28_touch_key_in6: rm-io28-touch-key-in6 {
> &gt;&gt; +			rockchip,pins =
> &gt;&gt; +				&lt;1 RK_PC3 7 &amp;pcfg_pull_none&gt;;
> &gt;&gt; +			rockchip,rmio-pins =
> &gt;&gt; +				&lt;0 28 49&gt;;
> &gt;&gt; +		};
> &gt;&gt; +
> &gt;&gt; +		/omit-if-no-ref/
> &gt;&gt; +		rm_io28_touch_key_in7: rm-io28-touch-key-in7 {
> &gt;&gt; +			rockchip,pins =
> &gt;&gt; +				&lt;1 RK_PC3 7 &amp;pcfg_pull_none&gt;;
> &gt;&gt; +			rockchip,rmio-pins =
> &gt;&gt; +				&lt;0 28 50&gt;;
> &gt;&gt; +		};
> &gt;&gt; +
> &gt;&gt; +		/omit-if-no-ref/
> &gt;&gt; +		rm_io28_sai0_mclk: rm-io28-sai0-mclk {
> &gt;&gt; +			rockchip,pins =
> &gt;&gt; +				&lt;1 RK_PC3 7 &amp;pcfg_pull_none&gt;;
> &gt;&gt; +			rockchip,rmio-pins =
> &gt;&gt; +				&lt;0 28 51&gt;;
> &gt;&gt; +		};
> &gt;&gt; +
> &gt;&gt; +		/omit-if-no-ref/
> &gt;&gt; +		rm_io28_sai0_sclk: rm-io28-sai0-sclk {
> &gt;&gt; +			rockchip,pins =
> &gt;&gt; +				&lt;1 RK_PC3 7 &amp;pcfg_pull_none&gt;;
> &gt;&gt; +			rockchip,rmio-pins =
> &gt;&gt; +				&lt;0 28 52&gt;;
> &gt;&gt; +		};
> &gt;&gt; +
> &gt;&gt; +		/omit-if-no-ref/
> &gt;&gt; +		rm_io28_sai0_lrck: rm-io28-sai0-lrck {
> &gt;&gt; +			rockchip,pins =
> &gt;&gt; +				&lt;1 RK_PC3 7 &amp;pcfg_pull_none&gt;;
> &gt;&gt; +			rockchip,rmio-pins =
> &gt;&gt; +				&lt;0 28 53&gt;;
> &gt;&gt; +		};
> &gt;&gt; +
> &gt;&gt; +		/omit-if-no-ref/
> &gt;&gt; +		rm_io28_sai0_sdi0: rm-io28-sai0-sdi0 {
> &gt;&gt; +			rockchip,pins =
> &gt;&gt; +				&lt;1 RK_PC3 7 &amp;pcfg_pull_none&gt;;
> &gt;&gt; +			rockchip,rmio-pins =
> &gt;&gt; +				&lt;0 28 54&gt;;
> &gt;&gt; +		};
> &gt;
> &gt; Why are you defining all pins? This is wrong, your driver has to do it,
> &gt; not DTS. All these definitions when not used are just pointless.
> &gt;

Don't send HTML to us. I cannot parse above.

Best regards,
Krzysztof