[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VfDnuyqRyHpVK40qRR59XB3RHV-aDO72UDNhjLDbJHDPg@mail.gmail.com>
Date: Mon, 29 Dec 2025 11:31:42 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Matti Vaittinen <mazziesaccount@...il.com>
Cc: David Lechner <dlechner@...libre.com>,
Maxime Chevallier <maxime.chevallier@...tlin.com>, Jonathan Cameron <jic23@...nel.org>, nuno.sa@...log.com,
Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Marcelo Schmitt <marcelo.schmitt@...log.com>, Antoniu Miclaus <antoniu.miclaus@...log.com>,
Angelo Dureghello <adureghello@...libre.com>, Tobias Sperling <tobias.sperling@...ting.com>,
Eason Yang <j2anfernee@...il.com>, Marilene Andrade Garcia <marilene.agarcia@...il.com>,
Cosmin Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>, duje@...emihanovic.xyz,
herve.codina@...tlin.com, Rodolfo Giometti <giometti@...eenne.com>, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
thomas.petazzoni@...tlin.com
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: add Texas Instruments TLA 2528
On Mon, Dec 29, 2025 at 10:04 AM Matti Vaittinen
<mazziesaccount@...il.com> wrote:
> On 23/12/2025 20:26, David Lechner wrote:
> > On 12/23/25 9:55 AM, Maxime Chevallier wrote:
...
> > It looks like inputs can also be used as GPIOs, so
> >
> > gpio-controller: true
> > #gpio-cells:
> > const: 2
> >
> > would be appropriate (it doesn't matter if the driver doesn't
> > implement it, we know what the correct bindings are).
> >
> >> +
> >> + "#io-channel-cells":
> >> + const: 1
>
> I didn't check the data-sheet, but if the pins can be set to be GPIOs or
> ADC inputs, then I would require channels to be specified. It's only 8
> channels, so always listing channels that are present shouldn't be that
> big of a problem - and it should avoid one to add extra properties to
> denote channels used for GPIO if GPIOs need to be supported.
>
> Well, I am not insisting this, there are folks that know this stuff
> better than I :)
Why would we need an extra property for that? GPIO controller has a
property for valid_mask, should be enough to handle this case, no?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists