linux-kernel - RE: [PATCH V1 2/3] dt-bindings: power: sbs-battery: add polling interval property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <GV2PR06MB108094811EF351CEA446A1ACBD7BFA@GV2PR06MB10809.eurprd06.prod.outlook.com>
Date: Mon, 29 Dec 2025 09:50:27 +0000
From: LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>
To: Krzysztof Kozlowski <krzk@...nel.org>, "sre@...nel.org" <sre@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: GEO-CHHER-bsp-development <bsp-development.geo@...ca-geosystems.com>
Subject: RE: [PATCH V1 2/3] dt-bindings: power: sbs-battery: add polling
 interval property



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Monday, December 29, 2025 5:16 PM
> To: LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>; sre@...nel.org;
> robh@...nel.org; krzk+dt@...nel.org; conor+dt@...nel.org;
> linux-pm@...r.kernel.org; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Cc: GEO-CHHER-bsp-development
> <bsp-development.geo@...ca-geosystems.com>
> Subject: Re: [PATCH V1 2/3] dt-bindings: power: sbs-battery: add polling interval
> property
> 
> This email is not from Hexagon’s Office 365 instance. Please be careful while
> clicking links, opening attachments, or replying to this email.
> 
> 
> On 29/12/2025 09:56, LI Qingwu wrote:
> > Add the optional sbs,monitoring-interval-ms property for SBS-compliant
> > batteries to configure a periodic polling interval on systems without
> > interrupt support. The driver periodically checks the battery status
> > and notifies userspace of changes when this property is set, and
> > ignores it when a GPIO interrupt is available.
> >
> > The property defaults to 0 to preserve existing behaviour.
> >
> > Signed-off-by: LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>
> > ---
> >  .../bindings/power/supply/sbs,sbs-battery.yaml           | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/power/supply/sbs,sbs-battery.yaml
> > b/Documentation/devicetree/bindings/power/supply/sbs,sbs-battery.yaml
> > index 90b9d3d882a4..fbdd5dd5dda8 100644
> > ---
> > a/Documentation/devicetree/bindings/power/supply/sbs,sbs-battery.yaml
> > +++ b/Documentation/devicetree/bindings/power/supply/sbs,sbs-battery.y
> > +++ aml
> > @@ -59,6 +59,15 @@ properties:
> >        master implementation.
> >      type: boolean
> >
> > +  sbs,monitoring-interval-ms:
> > +    description:
> > +      Polling interval in milliseconds for battery status monitoring on
> > +      systems without interrupt support. The driver periodically checks
> > +      the battery status and notifies userspace of changes. Ignored when
> > +      GPIO interrupt is available.
> 
> 
> You described the desired Linux feature or behavior, not the actual hardware.
> The bindings are about the latter, so instead you need to rephrase the property
> and its description to match actual hardware
> capabilities/features/configuration etc.
> 

Thanks for the quick feedback!
How about this?

  sbs,monitoring-interval-ms:
    description:
      Polling interval in milliseconds for battery status monitoring.
      Intended for hardware designs where the battery's interrupt signal
      is not connected, necessitating periodic status checks to detect
      changes.

> 
> Best regards,
> Krzysztof