linux-kernel - Re: [PATCH v4 0/9] crypto: virtio: Some bugfix and enhancement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6bf766f5-1f77-0d71-2970-46cbe5512233@loongson.cn>
Date: Mon, 29 Dec 2025 10:09:07 +0800
From: Bibo Mao <maobibo@...ngson.cn>
To: "Michael S. Tsirkin" <mst@...hat.com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>
Cc: Gonglei <arei.gonglei@...wei.com>, Jason Wang <jasowang@...hat.com>,
 Eric Biggers <ebiggers@...nel.org>, linux-kernel@...r.kernel.org,
 kvm@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v4 0/9] crypto: virtio: Some bugfix and enhancement



On 2025/12/26 下午10:45, Michael S. Tsirkin wrote:
> On Thu, Dec 18, 2025 at 11:48:37AM +0800, Bibo Mao wrote:
>> There is problem when multiple processes add encrypt/decrypt requests
>> with virtio crypto device and spinlock is missing with command response
>> handling. Also there is duplicated virtqueue_kick() without lock hold.
>>
>> Here these two issues are fixed and the others are code clean up, such as
>> use common APIs for block size and iv size etc.
> 
> series:
> Acked-by: Michael S. Tsirkin <mst@...hat.com>
> 
> but you did not CC maintainers, you really should if you want this
> applied.
Oh, sorry, it is the first time I send patch relative with crypto 
subsystem.

Add Herbert and David, need I send a fresh version?

Regards
Bibo Mao
> 
>> ---
>> v3 ... v4:
>>    1. Remove patch 10 which adds ECB AES algo, since application and qemu
>>       backend emulation is not ready for ECB AES algo.
>>    2. Add Cc stable tag with patch 2 which removes duplicated
>>       virtqueue_kick() without lock hold.
>>
>> v2 ... v3:
>>    1. Remove NULL checking with req_data where kfree() is called, since
>>       NULL pointer is workable with kfree() API.
>>    2. In patch 7 and patch 8, req_data and IV buffer which are preallocated
>>       are sensitive data, memzero_explicit() is used even on error path
>>       handling.
>>    3. Remove duplicated virtqueue_kick() in new patch 2, since it is
>>       already called in previous __virtio_crypto_skcipher_do_req().
>>
>> v1 ... v2:
>>    1. Add Fixes tag with patch 1.
>>    2. Add new patch 2 - patch 9 to add ecb aes algo support.
>> ---
>> Bibo Mao (9):
>>    crypto: virtio: Add spinlock protection with virtqueue notification
>>    crypto: virtio: Remove duplicated virtqueue_kick in
>>      virtio_crypto_skcipher_crypt_req
>>    crypto: virtio: Replace package id with numa node id
>>    crypto: virtio: Add algo pointer in virtio_crypto_skcipher_ctx
>>    crypto: virtio: Use generic API aes_check_keylen()
>>    crypto: virtio: Remove AES specified marcro AES_BLOCK_SIZE
>>    crypto: virtio: Add req_data with structure virtio_crypto_sym_request
>>    crypto: virtio: Add IV buffer in structure virtio_crypto_sym_request
>>    crypto: virtio: Add skcipher support without IV
>>
>>   drivers/crypto/virtio/virtio_crypto_common.h  |   2 +-
>>   drivers/crypto/virtio/virtio_crypto_core.c    |   5 +
>>   .../virtio/virtio_crypto_skcipher_algs.c      | 113 +++++++++---------
>>   3 files changed, 62 insertions(+), 58 deletions(-)
>>
>>
>> base-commit: ea1013c1539270e372fc99854bc6e4d94eaeff66
>> -- 
>> 2.39.3