linux-kernel - Re: [PATCH v1 1/1] serial: core: Restore sysfs fwnode information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aVJ2LFT-ywYzJ3Jo@smile.fi.intel.com>
Date: Mon, 29 Dec 2025 14:38:04 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
	Linus Walleij <linusw@...nel.org>
Cc: Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v1 1/1] serial: core: Restore sysfs fwnode information

On Mon, Dec 29, 2025 at 05:18:14AM +0200, Dmitry Baryshkov wrote:
> On Mon, Dec 22, 2025 at 11:55:26AM +0100, Marek Szyprowski wrote:

...

> I can confirm that this patch fixes the breakage on Qualcomm devices.
> Please send it as a proper patch (though I'd say, the flag should only
> be set only if dev->of_node != NULL).
> 
> An alternative is to introduce dev_set_node_from_dev() which mimics both
> dev_set_node() and device_set_of_node_from_dev().

While I am on vacation, I have a brief look at the report and fix and the
discussion. There are several ongoing tasks that may collide with this:

- the desire to split device.h, so we have something like device/fwnode.h with
all related APIs listed there

- taking these, it might be good to have device_set_used_node() as a combination
of the above and also device_is_node_used() to be used in its solely user of pin
control core

- the proper understanding of this flag to begin with and how it may be related
to ACPI-based platforms (or non-DT in general)

- with that done, it might be a room to see if the flag actually should be
somewhere in fwnode structure or elsewhere

- or we can revisit the whole design and see if we can get rid of the flag

+Cc: Linus for searching for his comments, thoughts, etc.

-- 
With Best Regards,
Andy Shevchenko