linux-kernel - Re: [PATCH v1] FROMLIST: driver: bluetooth: hci_qca: Always perform cleanup on every setup failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c39224af-f228-41f6-abd1-bbc79b970028@oss.qualcomm.com>
Date: Mon, 29 Dec 2025 14:02:34 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: jinwli <jinwang.li@....qualcomm.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>
Cc: linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, cheng.jiang@....qualcomm.com,
        quic_chezhou@...cinc.com, wei.deng@....qualcomm.com,
        shuai.zhang@....qualcomm.com, mengshi.wu@....qualcomm.com
Subject: Re: [PATCH v1] FROMLIST: driver: bluetooth: hci_qca: Always perform
 cleanup on every setup failure

On 12/22/25 1:38 PM, jinwli wrote:
> The retry logic in qca_setup combined error handling and
> retry gating under a single condition. This caused the final failed
> attempt (when retries reached MAX_INIT_RETRIES) to return without
> performing cleanup.
> 
> So only jumping to retry when there is a error and retries have not
> reached MAX_INIT_RETRIES.
> 
> Signed-off-by: jinwli <jinwang.li@....qualcomm.com>

Please fix your git name (unless that is how you actually write your name)

Why the 'FROMLIST:' in the title? It seems like you're the first submitter:

https://lore.kernel.org/all/?q=Always+perform+cleanup+on+every+setup+failure

Konrad