linux-kernel - Re: [PATCH v1 2/4] platform/x86/intel/hid: Stop creating a platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gyhVFA65YCqrz7WiY=4H+dhKb6FYMo06sU-hF=4fLS4Q@mail.gmail.com>
Date: Mon, 29 Dec 2025 14:07:23 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Linux ACPI <linux-acpi@...r.kernel.org>, 
	LKML <linux-kernel@...r.kernel.org>, Bjorn Helgaas <helgaas@...nel.org>, 
	Zhang Rui <rui.zhang@...el.com>, Chen Yu <yu.c.chen@...el.com>, 
	Mika Westerberg <mika.westerberg@...ux.intel.com>, Linux PCI <linux-pci@...r.kernel.org>, 
	Alex Hung <alexhung@...il.com>, Hans de Goede <hansg@...nel.org>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	platform-driver-x86@...r.kernel.org, AceLan Kao <acelan.kao@...onical.com>
Subject: Re: [PATCH v1 2/4] platform/x86/intel/hid: Stop creating a platform device

On Sun, Dec 28, 2025 at 8:13 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Mon, Dec 15, 2025 at 02:35:05PM +0100, Rafael J. Wysocki wrote:
> >
> > Now that "system" devices are represented as platform devices, they
> > are not claimed by the PNP ACPI scan handler any more and the Intel
> > HID platform devices should be created by the ACPI core, so the
> > driver does not need to attempt to create a platform device by
> > itself.
> >
> > Accordingly, make it stop doing so.
> >
> > No intentional functional impact.
>
> ...
>
> >       .remove = intel_hid_remove,
> >  };
>
> >
>
> This blank line now can also be removed as the module_platform_driver() coupled
> with the above structure initialiser.
>
> > -/*
> > - * Unfortunately, some laptops provide a _HID="INT33D5" device with
> > - * _CID="PNP0C02".  This causes the pnpacpi scan driver to claim the
> > - * ACPI node, so no platform device will be created.  The pnpacpi
> > - * driver rejects this device in subsequent processing, so no physical
> > - * node is created at all.
> > - *
> > - * As a workaround until the ACPI core figures out how to handle
> > - * this corner case, manually ask the ACPI platform device code to
> > - * claim the ACPI node.
> > - */
> > -static acpi_status __init
> > -check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)
> > -{
> > -     const struct acpi_device_id *ids = context;
> > -     struct acpi_device *dev = acpi_fetch_acpi_dev(handle);
> > -
> > -     if (dev && acpi_match_device_ids(dev, ids) == 0)
> > -             if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL)))
> > -                     dev_info(&dev->dev,
> > -                              "intel-hid: created platform device\n");
> > -
> > -     return AE_OK;
> > -}
> > -
> > -static int __init intel_hid_init(void)
> > -{
> > -     acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
> > -                         ACPI_UINT32_MAX, check_acpi_dev, NULL,
> > -                         (void *)intel_hid_ids, NULL);
> > -
> > -     return platform_driver_register(&intel_hid_pl_driver);
> > -}
> > -module_init(intel_hid_init);
> > -
> > -static void __exit intel_hid_exit(void)
> > -{
> > -     platform_driver_unregister(&intel_hid_pl_driver);
> > -}
> > -module_exit(intel_hid_exit);
> > +module_platform_driver(intel_hid_pl_driver);

Feel free to send a patch to remove it then, perhaps along with the
one in the other driver.