linux-kernel - Re: [PATCH v4 3/3] kselftest: devices: Add sample board file for XPS 13 9300

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78b4f1f60563fc854f5f4a54b42e0bac60715070.camel@collabora.com>
Date: Mon, 29 Dec 2025 10:42:17 -0300
From: Nícolas "F. R. A. Prado" <nfraprado@...labora.com>
To: Askar Safin <safinaskar@...il.com>
Cc: Tim.Bird@...y.com, bhelgaas@...gle.com, dan.carpenter@...aro.org, 
	davidgow@...gle.com, devicetree@...r.kernel.org, dianders@...omium.org, 
	gregkh@...uxfoundation.org, groeck@...omium.org, kernel@...labora.com, 
	kernelci@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, linux-pci@...r.kernel.org, 
	linux-usb@...r.kernel.org, robh+dt@...nel.org, saravanak@...gle.com, 
	shuah@...nel.org
Subject: Re: [PATCH v4 3/3] kselftest: devices: Add sample board file for
 XPS 13 9300

On Sun, 2025-12-28 at 08:47 +0300, Askar Safin wrote:
> "Nícolas F. R. A. Prado" <nfraprado@...labora.com>:
> > Add a sample board file describing the file's format and with the
> > list
> > of devices expected to be probed on the XPS 13 9300 machine as an
> > example x86 platform.
> 
> And now "Dell Inc.,XPS 13 9300.yaml" became the only file in the
> repository,
> which has space in its name:
> 
> $ find . -name '* *'
> ./tools/testing/selftests/devices/probe/boards/Dell Inc.,XPS 13
> 9300.yaml
> 
> I kindly ask you to rename file. New name should not contain space or
> comma
> in it.

While I understand it might be inconvenient that this is the only file
with a space in its name, that is exactly the string that is reported
by DMI, so it is natural that it would be used for the filename.

Besides, I'm not aware of there being a style guide rule that prohibits
space in filenames in the kernel tree, or that could have easily be
detected by checkpatch during submission.

Furthermore, not containing a comma is not even feasible, there are
tons of dt-binding filenames containing commas in the tree.

> 
> The file name in its current form breaks tools. For example, it
> breaks
> "xargs".
> 
> For example, the following will work in "fs" directory:
> 
> stable/fs$ find . | xargs chmod -w
> 
> But it will not work in root of source tree because of this
> "Dell Inc.,XPS 13 9300.yaml" file:
> 
> stable$ find . | xargs chmod -w
> chmod: cannot access
> './tools/testing/selftests/devices/probe/boards/Dell': No such file
> or directory
> chmod: cannot access 'Inc.,XPS': No such file or directory
> chmod: cannot access '13': No such file or directory
> chmod: cannot access '9300.yaml': No such file or directory

You can use 'find -print0' and 'xargs -0' instead so the space in the
filename is not an issue.

-- 
Thanks,

Nícolas