linux-kernel - Re: [PATCH v2] bus: fsl-mc: fix an error handling in fsl_mc_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <231f6f66-6a3d-4166-9e1a-ae0d5bd7583d@web.de>
Date: Mon, 29 Dec 2025 15:28:27 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>, Su Hui <suhui@...china.com>,
 linuxppc-dev@...ts.ozlabs.org, Christophe Leroy <chleroy@...nel.org>,
 Dan Carpenter <dan.carpenter@...aro.org>,
 Ioana Ciornei <ioana.ciornei@....com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] bus: fsl-mc: fix an error handling in
 fsl_mc_device_add()

> If device_add() fails, call put_device() to drop the device
> reference.

Can the word wrapping become nicer?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n659

>            And put_device() triggers fsl_mc_device_release()
> which does the free. Thus just return after call put_device().

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n145

Regards,
Markus