linux-kernel - Re: [PATCH] dmaengine: fix a reference leak in __dma_async_device_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c12a697a-e777-42c5-8354-af8e3fba04d1@web.de>
Date: Mon, 29 Dec 2025 17:30:25 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>, dmaengine@...r.kernel.org,
 Dave Jiang <dave.jiang@...el.com>, Vinod Koul <vkoul@...nel.org>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: fix a reference leak in
 __dma_async_device_channel_register()

…
> +++ b/drivers/dma/dmaengine.c
…
> @@ -1102,6 +1103,7 @@ static int __dma_async_device_channel_register(struct dma_device *device,
>  	else
>  		dev_set_name(&chan->dev->device, "%s", name);
>  	rc = device_register(&chan->dev->device);
> +	dev_registered = true;
>  	if (rc)
>  		goto err_out_ida;
>  	chan->client_count = 0;
…

I find the additional variable assignment still questionable at this source code place.

Regards,
Markus