linux-kernel - Re: 回复：[PATCH v1 net-next 00/15] nbl driver for Nebulamatrix NICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d00ff0b-58b6-484e-b5cf-202ba839acd3@redhat.com>
Date: Mon, 29 Dec 2025 17:41:29 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Illusion Wang <illusion.wang@...ula-matrix.com>,
 Dimon <dimon.zhao@...ula-matrix.com>, Alvin <alvin.wang@...ula-matrix.com>,
 Sam <sam.chen@...ula-matrix.com>, netdev <netdev@...r.kernel.org>
Cc: open list <linux-kernel@...r.kernel.org>
Subject: Re: 回复：[PATCH v1 net-next 00/15] nbl driver for Nebulamatrix NICs

On 12/29/25 2:47 AM, Illusion Wang wrote:
> 发件人：Paolo Abeni <pabeni@...hat.com>
> 发送时间：2025年12月23日(周二) 15:08
> 收件人：Illusion Wang<illusion.wang@...ula-matrix.com>; Dimon<dimon.zhao@...ula-matrix.com>; Alvin<alvin.wang@...ula-matrix.com>; Sam<sam.chen@...ula-matrix.com>; netdev<netdev@...r.kernel.org>
> 抄　送：open list<linux-kernel@...r.kernel.org>
> 主　题：Re: [PATCH v1 net-next 00/15] nbl driver for Nebulamatrix NICs
> 
> 
> On 12/23/25 4:50 AM, illusion.wang wrote:
>> The patch series add the nbl driver, which will support the nebula-matrix 18100 and 18110 series 
>> of network cards.
>> This submission is the first phase. which includes the PF-based and VF-based Ethernet transmit 
>> and receive functionality. Once this is merged. will submit addition patches to implement support
>> for other features. such as ethtool support, debugfs support and etc.
>> Our Driver architecture  supports Kernel Mode and Coexistence Mode(kernel and dpdk)
> 
> Not a real review, but this series has several basic issues:
> 
> - each patch should compile and build without warnings on all arches
> - don't use inline in c code
> - avoid using 'module_params'
> - the preferred line width is still 80 chars
>>>>>>
> 
> Thanks for your quick reply!
> However, I noticed that at
> https://github.com/torvalds/linux/commit/bdc48fa11e46f867ea4d75fa59ee87a7f48be144,
> And the checkpatch tool checks for a line width of 100 columns. If we make the change to 80 characters, it might reduce readability.
> Could our driver set the limit to 100 columns instead?

Please use consistent top quoting in your next replies. This one is
quite unreadable.

Networking still uses 80 column boundaries: please adapt your code
accordingly.

Thanks,

Paolo