linux-kernel - Re: [PATCH v3 13/14] ntfs: add Kconfig and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd8peJUopYfxxNE6KfFMWiXerR0d_3vyN39yn+WCT_DdVg@mail.gmail.com>
Date: Tue, 30 Dec 2025 08:08:03 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Matthew Wilcox <willy@...radead.org>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, hch@...radead.org, hch@....de, 
	tytso@....edu, jack@...e.cz, djwong@...nel.org, josef@...icpanda.com, 
	sandeen@...deen.net, rgoldwyn@...e.com, xiang@...nel.org, dsterba@...e.com, 
	pali@...nel.org, ebiggers@...nel.org, neil@...wn.name, amir73il@...il.com, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	iamjoonsoo.kim@....com, cheol.lee@....com, jay.sim@....com, gunho.lee@....com
Subject: Re: [PATCH v3 13/14] ntfs: add Kconfig and Makefile

On Tue, Dec 30, 2025 at 1:38 AM Matthew Wilcox <willy@...radead.org> wrote:
>
> On Mon, Dec 29, 2025 at 07:59:31PM +0900, Namjae Jeon wrote:
> > +++ b/fs/ntfs/Makefile
> > @@ -0,0 +1,18 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +#
> > +# Makefile for the ntfs filesystem support.
> > +#
> > +
> > +# to check robot warnings
>
> What does this comment mean?  I see ntfs3 also has this, so was this a
> case of blindly copying?
Yes, It is added while syncing with ntfs3. I'll remove it.
>
> > +ccflags-y += -Wint-to-pointer-cast \
> > +        $(call cc-option,-Wunused-but-set-variable,-Wunused-const-variable) \
> > +        $(call cc-option,-Wold-style-declaration,-Wout-of-line-declaration)
>
> -Wint-to-pointer-cast is already enabled by default,
> -Wunused-but-set-variable is enabled by -Wall, so both of these can be
> dropped I think.
Okay, I will remove it also.
Thanks for your review!
>