[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aVMQGqydQPqhsrEJ@google.com>
Date: Mon, 29 Dec 2025 15:34:50 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH 3/5] selftests: kvm: renumber some sync points in amx_test
On Wed, Dec 24, 2025, Paolo Bonzini wrote:
> Make room for the next test; separated for ease of review.
Heh, but after review, the discontiguous sync numbers are super confusing. Rather
than use arbitrary, incrementing numbers, what if we specify the action the host
should take? Then there's very little "magic" or implicit synchronization between
the guest and host. The only downside is that the "stage" prints are useless/lost,
but IMO that's largely a non-issue.
Tangentially related, the test doesn't ever verify that a #NM actually occurs, now
would be a good time to address that.
Full set of patches attached.
View attachment "0001-KVM-selftests-Use-named-sync-actions-in-AMX-test-ins.patch" of type "text/x-diff" (6603 bytes)
View attachment "0002-KVM-selftests-Extend-AMX-test-to-set-XFD-with-active.patch" of type "text/x-diff" (1732 bytes)
View attachment "0003-KVM-selftests-Add-test-to-verify-KVM-allows-loading-.patch" of type "text/x-diff" (3641 bytes)
View attachment "0004-KVM-selftests-Verify-TILELOADD-actually-NM-faults-wh.patch" of type "text/x-diff" (2912 bytes)
Powered by blists - more mailing lists