linux-kernel - [PATCH] Input: goodix - fix inverted Y coordinate on SUPI S10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251230221639.582406-1-yajatapps3@gmail.com>
Date: Tue, 30 Dec 2025 17:16:39 -0500
From: Yajat Kumar <yajatapps3@...il.com>
To: Hans de Goede <hansg@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org (open list:GOODIX TOUCHSCREEN),
	linux-kernel@...r.kernel.org (open list)
Cc: Yajat Kumar <yajatapps3@...il.com>
Subject: [PATCH] Input: goodix - fix inverted Y coordinate on SUPI S10

The touchscreen on the SUPI S10 reports inverted Y coordinates, causing
touch input to be mirrored vertically relative to the display.

Add a DMI-based quirk to invert the Y coordinate on this device so that
touch input matches the display orientation.

Tested on SUPI S10 tablet with Goodix touchscreen controller.

Signed-off-by: Yajat Kumar <yajatapps3@...il.com>
---
 drivers/input/touchscreen/goodix.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index f8798d11ec03..d675a85a9312 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -160,6 +160,22 @@ static const struct dmi_system_id inverted_x_screen[] = {
 	{}
 };
 
+/*
+ * Those tablets have their y coordinate inverted
+ */
+static const struct dmi_system_id inverted_y_screen[] = {
+#if defined(CONFIG_DMI) && defined(CONFIG_X86)
+	{
+		.ident = "SUPI S10",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SUPI"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S10")
+		},
+	},
+#endif
+	{}
+};
+
 /**
  * goodix_i2c_read - read data from a register of the i2c slave device.
  *
@@ -1212,6 +1228,12 @@ static int goodix_configure_dev(struct goodix_ts_data *ts)
 			"Applying 'inverted x screen' quirk\n");
 	}
 
+	if (dmi_check_system(inverted_y_screen)) {
+		ts->prop.invert_y = true;
+		dev_dbg(&ts->client->dev,
+			"Applying 'inverted y screen' quirk\n");
+	}
+
 	error = input_mt_init_slots(ts->input_dev, ts->max_touch_num,
 				    INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
 	if (error) {
-- 
2.51.0