linux-kernel - Re: [PATCH v2 2/6] staging: iio: ad9832: convert to guard(mutex)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vcr76Z=npXr0pu57oCrgmSWsLO4uB9qKLmmxSKap4R9MQ@mail.gmail.com>
Date: Wed, 31 Dec 2025 00:50:54 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Tomas Borquez <tomasborquez13@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, 
	David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org, 
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 2/6] staging: iio: ad9832: convert to guard(mutex)

On Tue, Dec 30, 2025 at 10:35 PM Tomas Borquez <tomasborquez13@...il.com> wrote:
>
> Use guard(mutex) for cleaner lock handling and simpler error paths.

...

Don't remember if it was in the previous rounds of review or somewhere
else, but Jonathan (? IIRC) suggestd to use

  ret = foo(...);
  if (ret)
   return ret;
  break;
  ...
  return len;

However, this one just duplicates what is already in use. Have you
checked the bloat-o-meter before and after and see if there is any
difference in the compiled object file?

-- 
With Best Regards,
Andy Shevchenko