linux-kernel - Re: [PATCH v3] mmc: host: sdhci-msm: Add support for wrapped keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02be322b-e49b-d7b9-c6f5-7b4c25e7b680@oss.qualcomm.com>
Date: Tue, 30 Dec 2025 11:36:33 +0530
From: Neeraj Soni <neeraj.soni@....qualcomm.com>
To: Eric Biggers <ebiggers@...nel.org>
Cc: adrian.hunter@...el.com, ulf.hansson@...aro.org, abel.vesa@...aro.org,
        linux-mmc@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Wenjia Zhang <wenjia.zhang@....qualcomm.com>
Subject: Re: [PATCH v3] mmc: host: sdhci-msm: Add support for wrapped keys

Hi

On 12/30/2025 3:55 AM, Eric Biggers wrote:
> On Mon, Dec 29, 2025 at 12:35:07PM +0530, Neeraj Soni wrote:
>> Add the wrapped key support for sdhci-msm by implementing the needed
>> methods in struct blk_crypto_ll_ops and setting the appropriate flag in
>> blk_crypto_profile::key_types_supported.
>>
>> Tested on SC7280 eMMC variant.
>>
>> How to test:
>>
>> Use the "wip-wrapped-keys-2024-12-09" tag from https://github.com/ebiggers/fscryptctl
>> and build fscryptctl that supports generating wrapped keys.
> 
> Use the official release of fscryptctl from
> https://github.com/google/fscryptctl instead.  v1.3.0 has wrapped key
> support.> 
> Note that the tag you linked to was for an older version of the wrapped
> key patches that wasn't compatible with the upstreamed version.  So it
> isn't plausible that it still works.  I'll assume you actually tested a
> different version and then just listed the wrong tag in your commit
> message.  To avoid confusion, I've deleted that old tag.
Okay. I Will test this patch using the fscryptctl you pointed and update the message accordingly in next patch.
> 
>> Tested-by: Wenjia Zhang <wenjia.zhang@....qualcomm.com>
>> Signed-off-by: Neeraj Soni <neeraj.soni@....qualcomm.com>
> 
> Otherwise this patch looks good.
Thanks.
> 
> Reviewed-by: Eric Biggers <ebiggers@...nel.org>
> 
> - Eric
> 
Regards
Neeraj