linux-kernel - RE: [PATCH 4/7] i2c: ljca: use i2c_adapter_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB56134EFE15DB24BFB7E6CCB793BCA@SJ0PR11MB5613.namprd11.prod.outlook.com>
Date: Tue, 30 Dec 2025 00:40:58 +0000
From: "Zhang, Lixu" <lixu.zhang@...el.com>
To: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>, Wolfram Sang
	<wsa+renesas@...g-engineering.com>, Mika Westerberg
	<mika.westerberg@...ux.intel.com>, Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>, Jan Dabros <jsd@...ihalf.com>, "Andi
 Shyti" <andi.shyti@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Binbin Zhou <zhoubinbin@...ngson.cn>, Fabrizio Castro
	<fabrizio.castro.jz@...esas.com>, "Cepeda Lopez, Israel A"
	<israel.a.cepeda.lopez@...el.com>, Hans de Goede <hansg@...nel.org>
CC: Bartosz Golaszewski <brgl@...nel.org>, "linux-i2c@...r.kernel.org"
	<linux-i2c@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH 4/7] i2c: ljca: use i2c_adapter_set_node()

>-----Original Message-----
>From: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
>Sent: Tuesday, December 23, 2025 6:07 PM
>To: Wolfram Sang <wsa+renesas@...g-engineering.com>; Mika Westerberg
><mika.westerberg@...ux.intel.com>; Andy Shevchenko
><andriy.shevchenko@...ux.intel.com>; Jan Dabros <jsd@...ihalf.com>; Andi
>Shyti <andi.shyti@...nel.org>; Zhang, Lixu <lixu.zhang@...el.com>; Sakari
>Ailus <sakari.ailus@...ux.intel.com>; Binbin Zhou <zhoubinbin@...ngson.cn>;
>Fabrizio Castro <fabrizio.castro.jz@...esas.com>; Cepeda Lopez, Israel A
><israel.a.cepeda.lopez@...el.com>; Hans de Goede <hansg@...nel.org>
>Cc: Bartosz Golaszewski <brgl@...nel.org>; linux-i2c@...r.kernel.org; linux-
>kernel@...r.kernel.org; linux-renesas-soc@...r.kernel.org; Bartosz
>Golaszewski <bartosz.golaszewski@....qualcomm.com>
>Subject: [PATCH 4/7] i2c: ljca: use i2c_adapter_set_node()
>
>Use the dedicated wrapper for setting the fwnode of the i2c_adapter.
>This allows us to hide the dereferencing of the embedded struct device.
>
>Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>

Reviewed-by: Zhang Lixu <lixu.zhang@...el.com>

Thanks,
Lixu

>---
> drivers/i2c/busses/i2c-ljca.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/i2c/busses/i2c-ljca.c b/drivers/i2c/busses/i2c-ljca.c index
>93274f0c2d72166bf017f65af797f418743b6a57..fb45019b1a0c583f19bce3523
>983a79d632da3da 100644
>--- a/drivers/i2c/busses/i2c-ljca.c
>+++ b/drivers/i2c/busses/i2c-ljca.c
>@@ -294,7 +294,7 @@ static int ljca_i2c_probe(struct auxiliary_device
>*auxdev,
> 		 dev_name(&auxdev->dev), dev_name(auxdev->dev.parent),
> 		 ljca_i2c->i2c_info->id);
>
>-	device_set_node(&ljca_i2c->adap.dev, dev_fwnode(&auxdev->dev));
>+	i2c_adapter_set_node(&ljca_i2c->adap, dev_fwnode(&auxdev->dev));
>
> 	i2c_set_adapdata(&ljca_i2c->adap, ljca_i2c);
> 	auxiliary_set_drvdata(auxdev, ljca_i2c);
>
>--
>2.47.3