linux-kernel - Re: [PATCH v5 1/2] dt-bindings: hwmon: add STEF48H28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFT9tymWkg+1Rp0rbWjjtenJmUKbcu_cpeY1MVRxMUTYGbRWDA@mail.gmail.com>
Date: Tue, 30 Dec 2025 08:46:32 +0800
From: Yungteng Hsu <hsu.yungteng@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: hwmon: add STEF48H28

Guenter Roeck <linux@...ck-us.net> 於 2025年12月30日週二 上午5:05寫道：
>
> On Mon, Dec 29, 2025 at 06:39:55PM +0800, Charles Hsu wrote:
> > Add device tree bindings for the hot-swap controller STEF48H28.
> >
> > Changes in v5:
> > - Move the change list into the commit message.
> >
> > Changes in v4:
> > - Fix an incorrect datasheet URL and update it to the correct reference.
> >
> > Changes in v3:
> > - Move the STEF48H28 Device Tree binding from
> >   trivial-devices.yaml to pmbus/stef48h28.yaml.
> >
> > Changes in v2:
> > - Fix the entry in trivial-devices.yaml by correcting the comment
> >   and compatible string ordering.
> >
> > Signed-off-by: Charles Hsu <hsu.yungteng@...il.com>
> > ---
>
> First there are no change logs, than this ... change log goes here,
> after "---".
>
> Nowadays it seems that 80+ % of my time is taken up with such
> trivialities, distracting from the actual code reviews.
>
> I really need to set up AI code reviews to handle that :-(.
>
> Guenter
>
Sorry about this. I’m still getting familiar with the expected
changelog conventions.
For the next step, should I put the changelog below the --- and resend
the patch?

Charles