[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAF7HswPViQh5qaHKtRQ+133jKa60Xh9+i8YTcdhfc9RohTOgYQ@mail.gmail.com>
Date: Tue, 30 Dec 2025 09:08:00 +0800
From: Kyle Hsieh <kylehsieh1995@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>,
Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Liam Beguin <liambeguin@...il.com>, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: adc: ltc2497: add support for ltc2305
On Sat, Dec 27, 2025 at 8:39 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Wed, Dec 24, 2025 at 01:37:14PM +0800, Kyle Hsieh wrote:
> > Add documentation for the 2-channel LTC2305 ADC in the
> > existing ltc2497 binding.
> > This enables automatic device tree matching for LTC2305
> > while using the LTC2309 driver (drivers/iio/adc/ltc2309.c),
>
> Not relevant sentence. And if I disable automatic matching in the
> kernel, does that invalidate binding? What about BSD?
>
> > since both ADCs share the same I2C interface and 12-bit SAR architecture.
> > The main difference is the number of channels (LTC2305: 2, LTC2309: 8).
>
> These two are fine. Just describe the hardware.
Thanks for the review.
I will remove the sentence about device tree matching and driver usage,
and keep the binding documentation focused on hardware description only.
Best regards,
Kyle Hsieh
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists