linux-kernel - Re: [PATCH v2 1/3] dt-bindings: pinctrl: spacemit: add K3 SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251230-jasper-loon-from-atlantis-c7c2df@quoll>
Date: Tue, 30 Dec 2025 10:06:01 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yixun Lan <dlan@...too.org>
Cc: Linus Walleij <linusw@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Troy Mitchell <troy.mitchell@...ux.spacemit.com>, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: pinctrl: spacemit: add K3 SoC support

On Fri, Dec 26, 2025 at 08:58:24PM +0800, Yixun Lan wrote:
> Add new compatible string for SpacemiT K3 SoC, the pinctrl IP shares
> almost same logic with previous K1 generation, but has different register
> offset and pin configuration, for example the drive strength and
> schmitter trigger settings has been changed.
> 
> Signed-off-by: Yixun Lan <dlan@...too.org>
> ---
>  .../devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml     | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> index d80e88aa07b4..d2cb994e30c1 100644
> --- a/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> @@ -11,7 +11,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: spacemit,k1-pinctrl
> +    enum:
> +      - spacemit,k1-pinctrl
> +      - spacemit,k3-pinctrl
>  
>    reg:
>      items:
> @@ -74,8 +76,12 @@ patternProperties:
>            drive-strength:
>              description: |
>                typical current when output high level.
> -              1.8V output: 11, 21, 32, 42 (mA)
> -              3.3V output: 7, 10, 13, 16, 19, 23, 26, 29 (mA)
> +              For K1 SoC, the settings show as below:
> +                1.8V output: 11, 21, 32, 42 (mA)
> +                3.3V output: 7, 10, 13, 16, 19, 23, 26, 29 (mA)
> +              For K3 SoC, the settings show as below:
> +                1.8V output: 2, 4, 6, 7, 9, 11, 13, 14, 21, 23, 25, 26, 28, 30, 31, 33 (mA)
> +                3.3V output: 3, 5, 7, 9, 11, 13, 15, 17, 25, 27, 29, 31, 33, 35, 37, 38 (mA)

This should be a schema rather than free form text. Add oneOf where each
item is description (1.8 V) + enum. This would be first commit for
converting text to schema for K1, which you grow for K3 in this commit.


Best regards,
Krzysztof