linux-kernel - Re: [PATCH v2 1/2] dt-bindings: regulator: Document TI TPS65185

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251230-rustling-mandrill-of-domination-ddc04b@quoll>
Date: Tue, 30 Dec 2025 10:08:57 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andreas Kemnade <andreas@...nade.info>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Guenter Roeck <linux@...ck-us.net>, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: Document TI TPS65185

On Sat, Dec 27, 2025 at 11:20:36AM +0100, Andreas Kemnade wrote:
> Document the TPS65185. GPIO names are same as in the datasheet except for
> the PWRUP pad which is described as "enable". That pin is optional because
> the rising edge corresponds to setting one register bit and falling edge
> to another register bit.

Nothing improved in the subject. Mark asked for proper prefix and you
used exactly the same prefix, so the same problem stays.

Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters


> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
>  .../devicetree/bindings/regulator/ti,tps65185.yaml | 99 ++++++++++++++++++++++
>  1 file changed, 99 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65185.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65185.yaml
> new file mode 100644
> index 000000000000..7cc5a895c2fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps65185.yaml
> @@ -0,0 +1,99 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/ti,tps65185.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI TPS65185 Power Management Integrated Circuit
> +
> +maintainers:
> +  - Andreas Kemnade <andreas@...nade.info>
> +
> +description:
> +  TPS65185 is a Power Management IC to provide Power for EPDs with one 3.3V
> +  switch, 2 symmetric LDOs behind 2 DC/DC converters, and one unsymmetric
> +  regulator for a compensation voltage.
> +
> +properties:
> +  compatible:
> +    const: ti,tps65185
> +
> +  reg:
> +    maxItems: 1
> +
> +  enable-gpios:
> +    description:
> +      PWRUP pin
> +    maxItems: 1
> +
> +  pwr-good-gpios:
> +    maxItems: 1
> +
> +  vcom-ctrl-gpios:
> +    maxItems: 1
> +
> +  wakeup-gpios:
> +    maxItems: 1
> +
> +  vin-supply:
> +    description:
> +      Supply for the whole chip. Some vendor kernels and devicetrees
> +      declare this as a non-existing GPIO named "pwrall".

GPIO cannot be non-existing. Anyway, use name matching the datasheet.

With these two things fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Best regards,
Krzysztof