linux-kernel - Re: [PATCH v1 3/9] exfat: reuse cache to improve exfat_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <PUZPR04MB631637893887AB587E1E3A9381BCA@PUZPR04MB6316.apcprd04.prod.outlook.com>
Date: Tue, 30 Dec 2025 09:05:52 +0000
From: "Yuezhang.Mo@...y.com" <Yuezhang.Mo@...y.com>
To: "chizhiling@....com" <chizhiling@....com>
CC: "brauner@...nel.org" <brauner@...nel.org>,
        "chizhiling@...inos.cn"
	<chizhiling@...inos.cn>,
        "jack@...e.cz" <jack@...e.cz>,
        "linkinjeon@...nel.org" <linkinjeon@...nel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "sj1557.seo@...sung.com" <sj1557.seo@...sung.com>,
        "viro@...iv.linux.org.uk"
	<viro@...iv.linux.org.uk>,
        "willy@...radead.org" <willy@...radead.org>,
        "Yuezhang.Mo@...y.com" <Yuezhang.Mo@...y.com>
Subject: Re: [PATCH v1 3/9] exfat: reuse cache to improve exfat_get_cluster

> -             if (exfat_ent_get(sb, *dclus, &content, NULL))
> -                     return -EIO;
> +             if (exfat_ent_get(sb, *dclus, &content, &bh))
> +                     goto err;

As you commented,  the buffer_head needs release if no error return.
Here, an error was returned, buffer_head had been released.

>  
>               *last_dclus = *dclus;
>               *dclus = content;
> @@ -299,7 +300,7 @@ int exfat_get_cluster(struct inode *inode, unsigned int cluster,                                                                                                  
>                               exfat_fs_error(sb,
>                                      "invalid cluster chain (i_pos %u, last_clus 0x%08x is EOF)",
>                                      *fclus, (*last_dclus));
> -                             return -EIO;
> +                             goto err;
>                       }
>
>                       break;
> @@ -309,6 +310,10 @@ int exfat_get_cluster(struct inode *inode, unsigned int cluster,
>                       cache_init(&cid, *fclus, *dclus);
>       }
>
> +     brelse(bh);
>       exfat_cache_add(inode, &cid);
>       return 0;
> +err:
> +     brelse(bh);
> +     return -EIO;
>  }