linux-kernel - Re: [PATCH net] net: wwan: iosm: Fix memory leak in ipc_mux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251230092532.1145752-1-zilin@seu.edu.cn>
Date: Tue, 30 Dec 2025 09:25:32 +0000
From: Zilin Guan <zilin@....edu.cn>
To: markus.elfring@....de
Cc: andrew+netdev@...n.ch,
	davem@...emloft.net,
	edumazet@...gle.com,
	jianhao.xu@....edu.cn,
	johannes@...solutions.net,
	kernel-janitors@...r.kernel.org,
	kuba@...nel.org,
	linux-kernel@...r.kernel.org,
	loic.poulain@....qualcomm.com,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	ryazanov.s.a@...il.com,
	zilin@....edu.cn
Subject: Re: [PATCH net] net: wwan: iosm: Fix memory leak in ipc_mux_deinit()

On Tue, Dec 30, 2025 at 10:15:05AM+0100, Markus Elfring wrote:
> …
> > +++ b/drivers/net/wwan/iosm/iosm_ipc_mux.c
> > @@ -456,6 +456,7 @@ void ipc_mux_deinit(struct iosm_mux *ipc_mux)
> >  	struct sk_buff_head *free_list;
> >  	union mux_msg mux_msg;
> >  	struct sk_buff *skb;
> > +	int i;
> …
> 
> May this variable be defined in the loop header instead?
> 
> Regards,
> Markus

Thanks for the suggestion.

I would prefer to keep the declaration at the top of the block to maintain 
consistency with the existing coding style of this function and to keep 
the patch focused strictly on the fix.

Regards,
Zilin Guan