[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251230013225.GA3037280-robh@kernel.org>
Date: Mon, 29 Dec 2025 19:32:25 -0600
From: Rob Herring <robh@...nel.org>
To: James Calligeros <jcalligeros99@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
Shengjiu Wang <shengjiu.wang@....com>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
Shenghao Ding <shenghao-ding@...com>, Kevin Lu <kevin-lu@...com>,
Baojun Xu <baojun.xu@...com>, linux-sound@...r.kernel.org,
devicetree@...r.kernel.org, imx@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
asahi@...ts.linux.dev
Subject: Re: [PATCH v2 2/7] ASoC: dt-bindings: update tdm-slot.txt references
to tdm-slot.yaml
On Sun, Dec 21, 2025 at 07:35:58PM +1000, James Calligeros wrote:
> Ensure that all references to tdm-slot.txt have been updated to
> tdm-slot.yaml, and are schema-compliant.
>
> Signed-off-by: James Calligeros <jcalligeros99@...il.com>
> ---
> .../bindings/sound/imx-audio-card.yaml | 14 ++++++--------
> .../bindings/sound/simple-card.yaml | 14 ++------------
> 2 files changed, 8 insertions(+), 20 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> index 3c75c8c78987..eb702f48d694 100644
> --- a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> @@ -31,6 +31,12 @@ patternProperties:
> $ref: /schemas/types.yaml#/definitions/string
> maxItems: 1
>
> + dai-tdm-slot-num:
> + $ref: tdm-slot.yaml#/$defs/dai-tdm-slot-num
> +
> + dai-tdm-slot-width:
> + $ref: tdm-slot.yaml#/$defs/dai-tdm-slot-width
Drop these and add just '$ref: tdm-slot.yaml#' up a level (with
'properties').
You may need 'unevaluatedProperties' or you can put
'dai-tdm-slot-num: true' here if you want to define which properties are
used.
> +
> format:
> description: audio format.
> items:
> @@ -38,14 +44,6 @@ patternProperties:
> - i2s
> - dsp_b
>
> - dai-tdm-slot-num:
> - description: see tdm-slot.txt.
> - $ref: /schemas/types.yaml#/definitions/uint32
> -
> - dai-tdm-slot-width:
> - description: see tdm-slot.txt.
> - $ref: /schemas/types.yaml#/definitions/uint32
> -
> playback-only:
> description: link is used only for playback
> $ref: /schemas/types.yaml#/definitions/flag
> diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml
> index 533d0a1da56e..a14716b2732f 100644
> --- a/Documentation/devicetree/bindings/sound/simple-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml
> @@ -27,14 +27,6 @@ definitions:
> description: dai-link uses bit clock inversion
> $ref: /schemas/types.yaml#/definitions/flag
>
> - dai-tdm-slot-num:
> - description: see tdm-slot.txt.
> - $ref: /schemas/types.yaml#/definitions/uint32
> -
> - dai-tdm-slot-width:
> - description: see tdm-slot.txt.
> - $ref: /schemas/types.yaml#/definitions/uint32
> -
> system-clock-frequency:
> description: |
> If a clock is specified and a multiplication factor is given with
> @@ -115,6 +107,8 @@ definitions:
>
> dai:
> type: object
> + $ref: tdm-slot.yaml#
> +
> properties:
> sound-dai:
> maxItems: 1
> @@ -133,10 +127,6 @@ definitions:
> bitclock-master:
> $ref: /schemas/types.yaml#/definitions/flag
>
> - dai-tdm-slot-num:
> - $ref: "#/definitions/dai-tdm-slot-num"
> - dai-tdm-slot-width:
> - $ref: "#/definitions/dai-tdm-slot-width"
> clocks:
> maxItems: 1
> system-clock-frequency:
>
> --
> 2.52.0
>
Powered by blists - more mailing lists