linux-kernel - Re: [PATCH 5/7] i2c: ls2x: use i2c_adapter_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <452b58c1-38b7-49a5-b2d7-4f9fd9f33b4d@loongson.cn>
Date: Tue, 30 Dec 2025 18:39:45 +0800
From: Binbin Zhou <zhoubinbin@...ngson.cn>
To: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
 Lixu Zhang <lixu.zhang@...el.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
 Israel Cepeda <israel.a.cepeda.lopez@...el.com>,
 Hans de Goede <hansg@...nel.org>
Cc: Bartosz Golaszewski <brgl@...nel.org>, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 5/7] i2c: ls2x: use i2c_adapter_set_node()


On 2025/12/23 18:06, Bartosz Golaszewski wrote:
> Use the dedicated wrapper for setting the fwnode of the i2c_adapter.
> This allows us to hide the dereferencing of the embedded struct device.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>

Reviewed-by: Binbin Zhou <zhoubinbin@...ngson.cn>

> ---
>   drivers/i2c/busses/i2c-ls2x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-ls2x.c b/drivers/i2c/busses/i2c-ls2x.c
> index b475dd27b7af94a22537f1000e95606774d6c7f2..217a55d7d90b2e515ef33e9014263958d9258b00 100644
> --- a/drivers/i2c/busses/i2c-ls2x.c
> +++ b/drivers/i2c/busses/i2c-ls2x.c
> @@ -312,7 +312,7 @@ static int ls2x_i2c_probe(struct platform_device *pdev)
>   	adap->owner = THIS_MODULE;
>   	adap->algo = &ls2x_i2c_algo;
>   	adap->timeout = msecs_to_jiffies(100);
> -	device_set_node(&adap->dev, dev_fwnode(dev));
> +	i2c_adapter_set_node(adap, dev_fwnode(dev));
>   	i2c_set_adapdata(adap, priv);
>   	strscpy(adap->name, pdev->name, sizeof(adap->name));
>   	init_completion(&priv->cmd_complete);
>