linux-kernel - Re: [PATCH v1] ACPI: scan: Use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e555049f-1170-9e7e-7564-1fe541c33dd8@linux.intel.com>
Date: Tue, 30 Dec 2025 13:53:58 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
cc: Linux ACPI <linux-acpi@...r.kernel.org>, 
    LKML <linux-kernel@...r.kernel.org>, Bjorn Helgaas <helgaas@...nel.org>, 
    Zhang Rui <rui.zhang@...el.com>, Chen Yu <yu.c.chen@...el.com>, 
    Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
    Mika Westerberg <mika.westerberg@...ux.intel.com>, 
    Linux PCI <linux-pci@...r.kernel.org>, Alex Hung <alexhung@...il.com>, 
    Hans de Goede <hansg@...nel.org>, platform-driver-x86@...r.kernel.org, 
    AceLan Kao <acelan.kao@...onical.com>
Subject: Re: [PATCH v1] ACPI: scan: Use resource_type() for resource type
 checking

On Tue, 30 Dec 2025, Rafael J. Wysocki wrote:

> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> To follow a well-established existing pattern, use resource_type() for
> resource type checking in acpi_scan_claim_resources().
> 
> No intentional functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
> 
> This is a follow-up to
> 
> https://lore.kernel.org/linux-acpi/7888874.EvYhyI6sBW@rafael.j.wysocki/
> 
> which is present in linux-next.
> 
> ---
>  drivers/acpi/scan.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -2624,7 +2624,7 @@ static void acpi_scan_claim_resources(st
>  		if ((res->flags & IORESOURCE_DISABLED) || res->end < res->start)
>  			continue;
>  
> -		if (res->flags & IORESOURCE_IO) {
> +		if (resource_type(res) == IORESOURCE_IO) {
>  			/*
>  			 * Follow the PNP system driver and on x86 skip I/O
>  			 * resources that start below 0x100 (the "standard PC
> @@ -2635,7 +2635,7 @@ static void acpi_scan_claim_resources(st
>  				continue;
>  			}
>  			r = request_region(res->start, resource_size(res), regionid);
> -		} else if (res->flags & IORESOURCE_MEM) {
> +		} else if (resource_type(res) == IORESOURCE_MEM) {
>  			r = request_mem_region(res->start, resource_size(res), regionid);
>  		} else {
>  			continue;
> 
> 
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.