linux-kernel - Re: [PATCH] scsi: hpsa: Fix memory leak in hpsa_undo_allocations_after_kdump_soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <667efc45-7970-4064-8357-0c1d9acf3d66@web.de>
Date: Tue, 30 Dec 2025 13:09:14 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Jianhao Xu <jianhao.xu@....edu.cn>, Zilin Guan <zilin@....edu.cn>,
 linux-scsi@...r.kernel.org, storagedev@...rochip.com,
 Don Brace <don.brace@...rochip.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 James Bottomley <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH] scsi: hpsa: Fix memory leak in
 hpsa_undo_allocations_after_kdump_soft_reset()

…
> +++ b/drivers/scsi/hpsa.c
> @@ -8212,6 +8212,8 @@ static void hpsa_undo_allocations_after_kdump_soft_reset(struct ctlr_info *h)
>  		h->monitor_ctlr_wq = NULL;
>  	}
>  
> +	kfree(h->reply_map);		/* init_one 1 */
> +	h->reply_map = NULL;		/* init_one 1 */

I find this reset statement redundant here.

>  	kfree(h);				/* init_one 1 */
>  }

Regards,
Markus