linux-kernel - Re: [PATCH 2/9] clk: realtek: Add basic reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251230-impetuous-quizzical-locust-daffda@quoll>
Date: Tue, 30 Dec 2025 13:20:06 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yu-Chun Lin <eleanor.lin@...ltek.com>
Cc: mturquette@...libre.com, sboyd@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, p.zabel@...gutronix.de, cylee12@...ltek.com, 
	jyanchou@...ltek.com, devicetree@...r.kernel.org, linux-clk@...r.kernel.org, 
	linux-kernel@...r.kernel.org, james.tai@...ltek.com, cy.huang@...ltek.com, 
	stanley_chang@...ltek.com
Subject: Re: [PATCH 2/9] clk: realtek: Add basic reset support

On Mon, Dec 29, 2025 at 03:53:06PM +0800, Yu-Chun Lin wrote:
> +
> +int rtk_reset_controller_add(struct device *dev,
> +			     struct rtk_reset_initdata *initdata)
> +{
> +	struct rtk_reset_data *data;
> +
> +	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> +

What sort of coding style do you use? There is absolutely never a blank
line between kzalloc and the if().

> +	if (!data)
> +		return -ENOMEM;
> +
> +	data->dev = dev;
> +	data->num_banks = initdata->num_banks;
> +	data->banks = initdata->banks;
> +	data->regmap = initdata->regmap;
> +	data->rcdev.owner = THIS_MODULE;

THIS_MODULE? so which module is exactly the owner - clk-rtk.ko or actual
driver?

This feels buggy, but I did not check your Makefile.

> +	data->rcdev.ops = &rtk_reset_ops;
> +	data->rcdev.dev = dev;
> +	data->rcdev.of_node = dev->of_node;
> +	data->rcdev.nr_resets = initdata->num_banks * 0x100;
> +	data->rcdev.of_xlate = rtk_of_reset_xlate;
> +	data->rcdev.of_reset_n_cells = 1;
> +
> +	return devm_reset_controller_register(dev, &data->rcdev);
> +}
> +EXPORT_SYMBOL_GPL(rtk_reset_controller_add);
> +
> diff --git a/drivers/clk/realtek/reset.h b/drivers/clk/realtek/reset.h
> new file mode 100644
> index 000000000000..cd446b098429
> --- /dev/null
> +++ b/drivers/clk/realtek/reset.h
> @@ -0,0 +1,36 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Copyright (C) 2019 Realtek Semiconductor Corporation

Ah, so that's why you sent probe() from ~10 years ago...

Best regards,
Krzysztof