linux-kernel - Re: [PATCH v2 06/11] dt-bindings: display: panel: Describe Samsung SOFEF03-M DDIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251230015359.GB3066456-robh@kernel.org>
Date: Mon, 29 Dec 2025 19:53:59 -0600
From: Rob Herring <robh@...nel.org>
To: Marijn Suijten <marijn.suijten@...ainline.org>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Sam Ravnborg <sam@...nborg.org>, David Airlie <airlied@...il.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Andy Gross <agross@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Jessica Zhang <jesszhan0024@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Simona Vetter <simona@...ll.ch>,
	Casey Connolly <casey.connolly@...aro.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Simona Vetter <simona.vetter@...ll.ch>,
	~postmarketos/upstreaming@...ts.sr.ht,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>,
	Martin Botka <martin.botka@...ainline.org>,
	Jami Kettunen <jami.kettunen@...ainline.org>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	Abhinav Kumar <quic_abhinavk@...cinc.com>,
	Kuogee Hsieh <quic_khsieh@...cinc.com>,
	Jessica Zhang <quic_jesszhan@...cinc.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Dmitry Baryshkov <lumag@...nel.org>
Subject: Re: [PATCH v2 06/11] dt-bindings: display: panel: Describe Samsung
 SOFEF03-M DDIC

On Sun, Dec 28, 2025 at 11:49:13PM +0100, Marijn Suijten wrote:
> On 2025-12-22 09:36:23, Krzysztof Kozlowski wrote:
> > On 22/12/2025 09:33, Krzysztof Kozlowski wrote:
> > >> +  - |
> > >> +    #include <dt-bindings/gpio/gpio.h>
> > >> +
> > >> +    dsi {
> > >> +        #address-cells = <1>;
> > >> +        #size-cells = <0>;
> > >> +        panel@0 {
> > >> +            compatible = "samsung,sofef03-m-amb609vp01";
> > >> +            reg = <0>;
> > >> +
> > >> +            reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
> > >> +
> > >> +            vci-supply = <&vreg_l11c_3p0>;
> > >> +            vddio-supply = <&vreg_l14a_1p8>;
> > >> +
> > >> +            port {
> > > 
> > > Not tested :/
> > 
> > Ah no, this one is correct. It's the other patch with similar compatible
> > which was not tested.
> 
> I think you mean:
> 
> 	.output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 		from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml
> 	.output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'port' is a required property
> 		from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml
> 
> Which looks to be fixed by including panel-common-dual.yaml and changing `port`
> to `ports` in the properties and required table?  At least the errors are gone,
> just asking if that is acceptable.

Considering it's a dual interface panel, yes, that's the right change.

Rob