linux-kernel - Re: [PATCH] iio:frequency:adf4377: Fix duplicated soft reset mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aVPMJFt07PG9oHMU@smile.fi.intel.com>
Date: Tue, 30 Dec 2025 14:57:08 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: SeungJu Cheon <suunj1331@...il.com>
Cc: antoniu.miclaus@...log.com, lars@...afoo.de,
	Michael.Hennerich@...log.com, jic23@...nel.org,
	dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio:frequency:adf4377: Fix duplicated soft reset mask

On Tue, Dec 30, 2025 at 09:36:09PM +0900, SeungJu Cheon wrote:
> The regmap_read_poll_timeout() uses ADF4377_0000_SOFT_RESET_R_MSK
> twice instead of checking both SOFT_RESET_MSK (bit 0) and
> SOFT_RESET_R_MSK (bit 7). This causes incomplete reset status check.
> 
> Fix by using both masks as done in regmap_update_bits() above.

Shouldn't we have a Fixes tag here?

-- 
With Best Regards,
Andy Shevchenko