linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: agatti: Address Gunyah memory alignment needs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1595f84b-91d0-4369-b1ff-713cf21472b1@oss.qualcomm.com>
Date: Tue, 30 Dec 2025 14:07:23 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Sumit Garg <sumit.garg@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
        krzk+dt@...nel.org, conor+dt@...nel.org, akhilpo@....qualcomm.com,
        vikash.garodia@....qualcomm.com, dikshita.agarwal@....qualcomm.com,
        robin.clark@....qualcomm.com, lumag@...nel.org,
        linux-kernel@...r.kernel.org, Sumit Garg <sumit.garg@....qualcomm.com>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: agatti: Address Gunyah memory
 alignment needs

On 12/30/25 5:46 AM, Sumit Garg wrote:
> On Mon, Dec 29, 2025 at 01:43:18PM +0100, Konrad Dybcio wrote:
>> On 12/29/25 8:12 AM, Sumit Garg wrote:
>>> From: Sumit Garg <sumit.garg@....qualcomm.com>
>>>
>>> Gunyah hypervisor requires it's memory start address to be 2MB aligned.
>>> So the address map for Agatti is updated to incorporate that requirement.
>>> This should be a backwards compatible DT change which should work with
>>> legacy QHEE based firmware stack too.
>>>
>>> Signed-off-by: Sumit Garg <sumit.garg@....qualcomm.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/agatti.dtsi | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
>>> index e705eb24160a..153916980ac0 100644
>>> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
>>> @@ -298,8 +298,8 @@ reserved_memory: reserved-memory {
>>>  		#size-cells = <2>;
>>>  		ranges;
>>>  
>>> -		hyp_mem: hyp@...00000 {
>>> -			reg = <0x0 0x45700000 0x0 0x600000>;
>>> +		hyp_mem: hyp@...00000 {
>>> +			reg = <0x0 0x45600000 0x0 0x700000>;
>>
>> On a second thought, please add a comment like:
>>
>> /* Gunyah requires the start of the region to be 2MiB-aligned, QHEE doesn't care */
>>
>> to prevent someone "fixing" it in the future
> 
> Sounds reasonable, I will add this comment on the next spin. I hope that
> I can keep you review tag with comment added.

Yeah, although as pointed out by the bot you'll need some bindings
updates to match

Konrad