linux-kernel - Re: [PATCH v2] mm/memblock: drop redundant 'struct page *' argument from memblock_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <176710164796.4000036.11847815060413161135.b4-ty@kernel.org>
Date: Tue, 30 Dec 2025 15:35:12 +0200
From: Mike Rapoport <rppt@...nel.org>
To: akpm <akpm@...ux-foundation.org>,
	david <david@...nel.org>,
	shengminghu512 <shengminghu512@...com>
Cc: Mike Rapoport <rppt@...nel.org>,
	"lorenzo.stoakes" <lorenzo.stoakes@...cle.com>,
	"Liam.Howlett" <Liam.Howlett@...cle.com>,
	vbabka <vbabka@...e.cz>,
	surenb <surenb@...gle.com>,
	mhocko <mhocko@...e.com>,
	linux-mm <linux-mm@...ck.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"hu.shengming" <hu.shengming@....com.cn>,
	"zhang.run" <zhang.run@....com.cn>
Subject: Re: [PATCH v2] mm/memblock: drop redundant 'struct page *' argument from memblock_free_pages()

On Mon, 29 Dec 2025 21:52:27 +0800, shengminghu512 wrote:
> memblock_free_pages() currently takes both a struct page * and the
> corresponding PFN. The page pointer is always derived from the PFN at
> call sites (pfn_to_page(pfn)), making the parameter redundant and also
> allowing accidental mismatches between the two arguments.
> 
> Simplify the interface by removing the struct page * argument and
> deriving the page locally from the PFN, after the deferred struct page
> initialization check. This keeps the behavior unchanged while making
> the helper harder to misuse.
> 
> [...]

Applied to for-next branch of memblock.git tree, thanks!

[1/1] mm/memblock: drop redundant 'struct page *' argument from memblock_free_pages()
      commit: 42496efbfba1741fd4f1278366249bce9d34884a

tree: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock
branch: for-next

--
Sincerely yours,
Mike.