linux-kernel - Re: [PATCH] fs: remove stale and duplicate forward declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202512302125.FNgHwu5z-lkp@intel.com>
Date: Tue, 30 Dec 2025 21:58:42 +0800
From: kernel test robot <lkp@...el.com>
To: Yuto Ohnuki <ytohnuki@...zon.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Yuto Ohnuki <ytohnuki@...zon.com>
Subject: Re: [PATCH] fs: remove stale and duplicate forward declarations

Hi Yuto,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on linus/master v6.19-rc3 next-20251219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yuto-Ohnuki/fs-remove-stale-and-duplicate-forward-declarations/20251229-151612
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20251229071401.98146-1-ytohnuki%40amazon.com
patch subject: [PATCH] fs: remove stale and duplicate forward declarations
config: nios2-allnoconfig (https://download.01.org/0day-ci/archive/20251230/202512302125.FNgHwu5z-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251230/202512302125.FNgHwu5z-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512302125.FNgHwu5z-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from block/bdev.c:14:
>> include/linux/blkdev.h:1656:48: warning: 'struct hd_geometry' declared inside parameter list will not be visible outside of this definition or declaration
    1656 |         int (*getgeo)(struct gendisk *, struct hd_geometry *);
         |                                                ^~~~~~~~~~~
--
   In file included from block/ioctl.c:4:
>> include/linux/blkdev.h:1656:48: warning: 'struct hd_geometry' declared inside parameter list will not be visible outside of this definition or declaration
    1656 |         int (*getgeo)(struct gendisk *, struct hd_geometry *);
         |                                                ^~~~~~~~~~~
   block/ioctl.c: In function 'blkdev_getgeo':
>> block/ioctl.c:564:40: error: passing argument 2 of 'disk->fops->getgeo' from incompatible pointer type [-Werror=incompatible-pointer-types]
     564 |         ret = disk->fops->getgeo(disk, &geo);
         |                                        ^~~~
         |                                        |
         |                                        struct hd_geometry *
   block/ioctl.c:564:40: note: expected 'struct hd_geometry *' but argument is of type 'struct hd_geometry *'
   cc1: some warnings being treated as errors


vim +1656 include/linux/blkdev.h

9208d414975895 Christoph Hellwig 2021-10-21  1642  
08f85851215100 Al Viro           2007-10-08  1643  struct block_device_operations {
3e08773c3841e9 Christoph Hellwig 2021-10-12  1644  	void (*submit_bio)(struct bio *bio);
69fe0f29892077 Ming Lei          2022-03-04  1645  	int (*poll_bio)(struct bio *bio, struct io_comp_batch *iob,
69fe0f29892077 Ming Lei          2022-03-04  1646  			unsigned int flags);
05bdb9965305bb Christoph Hellwig 2023-06-08  1647  	int (*open)(struct gendisk *disk, blk_mode_t mode);
ae220766d87cd6 Christoph Hellwig 2023-06-08  1648  	void (*release)(struct gendisk *disk);
05bdb9965305bb Christoph Hellwig 2023-06-08  1649  	int (*ioctl)(struct block_device *bdev, blk_mode_t mode,
05bdb9965305bb Christoph Hellwig 2023-06-08  1650  			unsigned cmd, unsigned long arg);
05bdb9965305bb Christoph Hellwig 2023-06-08  1651  	int (*compat_ioctl)(struct block_device *bdev, blk_mode_t mode,
05bdb9965305bb Christoph Hellwig 2023-06-08  1652  			unsigned cmd, unsigned long arg);
77ea887e433ad8 Tejun Heo         2010-12-08  1653  	unsigned int (*check_events) (struct gendisk *disk,
77ea887e433ad8 Tejun Heo         2010-12-08  1654  				      unsigned int clearing);
c3e33e043f5e9c Tejun Heo         2010-05-15  1655  	void (*unlock_native_capacity) (struct gendisk *);
4fc8728aa34f54 Al Viro           2024-05-21 @1656  	int (*getgeo)(struct gendisk *, struct hd_geometry *);
e00adcadf3af7a Christoph Hellwig 2020-11-03  1657  	int (*set_read_only)(struct block_device *bdev, bool ro);
76792055c4c8b2 Christoph Hellwig 2022-02-15  1658  	void (*free_disk)(struct gendisk *disk);
b3a27d0529c6e5 Nitin Gupta       2010-05-17  1659  	/* this callback is with swap_lock and sometimes page table lock held */
b3a27d0529c6e5 Nitin Gupta       2010-05-17  1660  	void (*swap_slot_free_notify) (struct block_device *, unsigned long);
e76239a3748c90 Christoph Hellwig 2018-10-12  1661  	int (*report_zones)(struct gendisk *, sector_t sector,
fdb9aed869f34d Damien Le Moal    2025-11-05  1662  			    unsigned int nr_zones,
fdb9aed869f34d Damien Le Moal    2025-11-05  1663  			    struct blk_report_zones_args *args);
050a4f341f35bf Jens Axboe        2023-01-04  1664  	char *(*devnode)(struct gendisk *disk, umode_t *mode);
9208d414975895 Christoph Hellwig 2021-10-21  1665  	/* returns the length of the identifier or a negative errno: */
9208d414975895 Christoph Hellwig 2021-10-21  1666  	int (*get_unique_id)(struct gendisk *disk, u8 id[16],
9208d414975895 Christoph Hellwig 2021-10-21  1667  			enum blk_unique_id id_type);
08f85851215100 Al Viro           2007-10-08  1668  	struct module *owner;
bbd3e064362e50 Christoph Hellwig 2015-10-15  1669  	const struct pr_ops *pr_ops;
0bdfbca8a623e2 Dmitry Osipenko   2021-08-20  1670  
0bdfbca8a623e2 Dmitry Osipenko   2021-08-20  1671  	/*
0bdfbca8a623e2 Dmitry Osipenko   2021-08-20  1672  	 * Special callback for probing GPT entry at a given sector.
0bdfbca8a623e2 Dmitry Osipenko   2021-08-20  1673  	 * Needed by Android devices, used by GPT scanner and MMC blk
0bdfbca8a623e2 Dmitry Osipenko   2021-08-20  1674  	 * driver.
0bdfbca8a623e2 Dmitry Osipenko   2021-08-20  1675  	 */
0bdfbca8a623e2 Dmitry Osipenko   2021-08-20  1676  	int (*alternative_gpt_sector)(struct gendisk *disk, sector_t *sector);
08f85851215100 Al Viro           2007-10-08  1677  };
08f85851215100 Al Viro           2007-10-08  1678  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki