linux-kernel - Re: [PATCH v2 1/3] scsi: lpfc: Fix memory leak in lpfc_config_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ab71d11-ef77-4181-a5d5-e785576c85be@web.de>
Date: Tue, 30 Dec 2025 17:01:32 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Jianhao Xu <jianhao.xu@....edu.cn>, Zilin Guan <zilin@....edu.cn>,
 linux-scsi@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 James Bottomley <James.Bottomley@...senPartnership.com>,
 Justin Tee <justin.tee@...adcom.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Paul Ely <paul.ely@...adcom.com>
Subject: Re: [PATCH v2 1/3] scsi: lpfc: Fix memory leak in
 lpfc_config_port_post()

…
> +++ b/drivers/scsi/lpfc/lpfc_init.c
…
> @@ -550,8 +549,7 @@ lpfc_config_port_post(struct lpfc_hba *phba)
>  	if (phba->intr_type == MSIX) {
>  		rc = lpfc_config_msi(phba, pmb);
>  		if (rc) {
> -			mempool_free(pmb, phba->mbox_mem_pool);
> -			return -EIO;
> +			goto out_free;
>  		}

You may omit curly brackets here.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc3#n197

>  		rc = lpfc_sli_issue_mbox(phba, pmb, MBX_POLL);
>  		if (rc != MBX_SUCCESS) {
…

Regards,
Markus