linux-kernel - Re: [PATCH 3/9] clk: realtek: Introduce a common probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202512310241.H75NfTMw-lkp@intel.com>
Date: Wed, 31 Dec 2025 02:14:15 +0800
From: kernel test robot <lkp@...el.com>
To: Yu-Chun Lin <eleanor.lin@...ltek.com>, mturquette@...libre.com,
	sboyd@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, p.zabel@...gutronix.de, cylee12@...ltek.com,
	jyanchou@...ltek.com
Cc: oe-kbuild-all@...ts.linux.dev, devicetree@...r.kernel.org,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	james.tai@...ltek.com, cy.huang@...ltek.com,
	stanley_chang@...ltek.com, eleanor.lin@...ltek.com
Subject: Re: [PATCH 3/9] clk: realtek: Introduce a common probe()

Hi Yu-Chun,

kernel test robot noticed the following build warnings:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on linus/master v6.19-rc3 next-20251219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yu-Chun-Lin/dt-bindings-clock-Add-Realtek-RTD1625-Clock-Reset-Controller/20251229-155549
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link:    https://lore.kernel.org/r/20251229075313.27254-4-eleanor.lin%40realtek.com
patch subject: [PATCH 3/9] clk: realtek: Introduce a common probe()
config: arc-randconfig-002-20251231 (https://download.01.org/0day-ci/archive/20251231/202512310241.H75NfTMw-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251231/202512310241.H75NfTMw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512310241.H75NfTMw-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from drivers/clk/realtek/common.c:7:
   drivers/clk/realtek/common.c: In function 'rtk_clk_probe':
>> drivers/clk/realtek/common.c:58:4: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'const unsigned int'} [-Wformat=]
       "Missing reset banks data though num_reset_banks is %lu\n",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:110:16: note: in definition of macro 'dev_printk_index_wrap'
      _p_func(dev, fmt, ##__VA_ARGS__);   \
                   ^~~
   include/linux/dev_printk.h:154:49: note: in expansion of macro 'dev_fmt'
     dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
                                                    ^~~~~~~
   drivers/clk/realtek/common.c:57:3: note: in expansion of macro 'dev_err'
      dev_err(dev,
      ^~~~~~~


vim +58 drivers/clk/realtek/common.c

    12	
    13	int rtk_clk_probe(struct platform_device *pdev, const struct rtk_clk_desc *desc)
    14	{
    15		int i, ret;
    16		struct device *dev = &pdev->dev;
    17		struct rtk_reset_initdata reset_initdata = { 0 };
    18	
    19		struct regmap *regmap = device_node_to_regmap(pdev->dev.of_node);
    20	
    21		if (IS_ERR(regmap)) {
    22			ret = PTR_ERR(regmap);
    23			dev_err(dev, "Failed to get regmap: %d\n", ret);
    24			return ret;
    25		}
    26	
    27		for (i = 0; i < desc->num_clks; i++)
    28			desc->clks[i]->regmap = regmap;
    29	
    30		for (i = 0; i < desc->clk_data->num; i++) {
    31			struct clk_hw *hw = desc->clk_data->hws[i];
    32	
    33			if (!hw)
    34				continue;
    35	
    36			ret = devm_clk_hw_register(dev, hw);
    37	
    38			if (ret) {
    39				dev_warn(dev, "failed to register hw of clk%d: %d\n", i,
    40					 ret);
    41				desc->clk_data->hws[i] = NULL;
    42			}
    43		}
    44	
    45		ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
    46						  desc->clk_data);
    47	
    48		if (ret) {
    49			dev_err(dev, "Failed to add clock provider\n");
    50			return ret;
    51		}
    52	
    53		if (!desc->num_reset_banks)
    54			return 0;
    55	
    56		if (!desc->reset_banks) {
    57			dev_err(dev,
  > 58				"Missing reset banks data though num_reset_banks is %lu\n",
    59				desc->num_reset_banks);
    60			return -EINVAL;
    61		}
    62	
    63		reset_initdata.regmap = regmap;
    64		reset_initdata.num_banks = desc->num_reset_banks;
    65		reset_initdata.banks = desc->reset_banks;
    66	
    67		return rtk_reset_controller_add(dev, &reset_initdata);
    68	}
    69	EXPORT_SYMBOL_GPL(rtk_clk_probe);
    70	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki