linux-kernel - Re: [PATCH v1 2/4] wifi: rsi: sdio: Reduce use of #ifdef for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ngbudwaq4rdb6u4r3gn6ub7hqctq3qgienciuylgqsglougnk@ckdj3wrhzyqy>
Date: Tue, 30 Dec 2025 19:56:57 +0100
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Johannes Berg <johannes@...solutions.net>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org, 
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/4] wifi: rsi: sdio: Reduce use of #ifdef for
 CONFIG_PM

On Mon, Dec 29, 2025 at 11:36:02AM +0100, Johannes Berg wrote:
> On Wed, 2025-12-17 at 12:09 +0100, Uwe Kleine-König wrote:
> > This drops two #ifdefs (which is good because they are ugly) without
> > changing semantics. This also improves compile coverage because all the
> > code in the first #ifdef block is now compiled even for configurations
> > without CONFIG_PM (and then thrown away).
> 
> This didn't build, and given that we never got 1/4 I'm going to assume
> it wasn't destined to the wireless tree.

Yes, this depends on patch #1, I expected the series to go in via
whatever tree sdio usually goes in and didn't notice that all users are
in the wireless subsystem.

The kernel robot also found an issue[1] that needs addressing (probably
by dropping patch #2 from the series). Will look into that next year.

Best regards
Uwe

[1] https://lore.kernel.org/all/202512210032.6Skz9prt-lkp@intel.com/

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)