[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <92f47140-445a-45e0-8e6c-0b09076444ac@quicinc.com>
Date: Wed, 31 Dec 2025 12:06:18 +0530
From: Ayushi Makhija <quic_amakhija@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
<freedreno@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <robdclark@...il.com>,
<dmitry.baryshkov@....qualcomm.com>, <sean@...rly.run>,
<marijn.suijten@...ainline.org>, <andersson@...nel.org>,
<robh@...nel.org>, <robh+dt@...nel.org>, <krzk+dt@...nel.org>,
<konradybcio@...nel.org>, <conor+dt@...nel.org>,
<andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>,
<rfoss@...nel.org>, <Laurent.pinchart@...asonboard.com>,
<jonathan@...ek.ca>, <jonas@...boo.se>, <jernej.skrabec@...il.com>,
<quic_rajeevny@...cinc.com>, <quic_vproddut@...cinc.com>
Subject: Re: [PATCH v4 1/5] dt-bindings: display: msm-dsi-phy-7nm: document
the QCS8300 DSI PHY
On 12/27/2025 4:43 PM, Krzysztof Kozlowski wrote:
> On Thu, Dec 25, 2025 at 08:51:30PM +0530, Ayushi Makhija wrote:
>> The QCS8300 MDSS DSI PHY is the same 5nm PHY IP as on SA8775P, with
>> identical register layout and programming model. Model this by using
>> a QCS8300 specific compatible with a qcom,sa8775p-dsi-phy-5nm fallback,
>> and update the schema to require this two entry form for QCS8300 while
>> keeping existing single compatible users valid.
>
> Last sentence is redundant. I asked to explain the hardware, not to tell
> us how Devicetree works. Write concise and informative commit msgs which
> tell non-obvious things. Not what you did. I alreaded asked this - do
> not state the obvious, do not copy the subject.
>
> The only useful part of your commit msg is first sentence - two lines,
> so 33%. Remaining four lines, so 66%, is obvious.
>
> Best regards,
> Krzysztof
>
Hi Krzysztof, sure will update the commit description accordingly.
Thanks,
Ayushi
Powered by blists - more mailing lists