linux-kernel - Re: [PATCH 1/4] dt-bindings: reset: spacemit: Add K3 reset IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH1PCMbKwBUJoVfL-wqsd_5RWNVFVVC_UPxk2B3VFeRkDertng@mail.gmail.com>
Date: Wed, 31 Dec 2025 15:58:03 +0800
From: Guodong Xu <guodong@...cstar.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>, 
	Alex Elder <elder@...cstar.com>, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	spacemit@...ts.linux.dev
Subject: Re: [PATCH 1/4] dt-bindings: reset: spacemit: Add K3 reset IDs

Hi, Krzysztof

On Tue, Dec 30, 2025 at 8:24 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 30/12/2025 13:21, Krzysztof Kozlowski wrote:
> > On Mon, Dec 29, 2025 at 07:04:04PM +0800, Guodong Xu wrote:
> >> Add reset IDs for SpacemiT K3 SoC.
> >
> > Why? Where is the actual binding? You have entire commit msg to explain
> > that, instead of duplicating subject.
>
> ... also because then I would ask what is the compatible and why the
> filename does not match the compatible.
>

Thank you for the review.

I see your point now. It's my mistake not explaining the relationship
between K3 reset and clock controller. I will update the commit message
in v2.

K3 reset devices are registered at run time as auxiliary devices by the
k3 ccu driver. This way, they don't have their own yaml binding file, but
reuse the K3 ccu binding, which is built on top of k1 syscon:
Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml

>
> ... also because then I would ask what is the compatible and why the
> filename does not match the compatible.

For the filename, since it lists the index values for reset data, I
chose to put it into include/dt-bindings/reset/spacemit,k3-resets.h,
which mirrors the clock part at include/dt-bindings/clock/spacemit,k3-clocks.h.

I will update the yaml file (spacemit,k1-syscon.yaml) in the v2 version
to document K3 reset support and include the reset header in the
description, so people can clearly link 'spacemit,k3-resets.h' with the
binding compatible.

> >
> > I am pretty sure I already asked this for a different patchset from
> > you...

I apologize for that. I will be more careful in future submissions.

Best regards,
Guodong

> >
> >
> >>
> Best regards,
> Krzysztof