linux-kernel - Re: [PATCH v4 3/7] dt-bindings: leds: Add virtual LED group controller bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cfe39a0e-e475-4d0d-bad6-461b25f430ef@kernel.org>
Date: Wed, 31 Dec 2025 09:03:21 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jonathan Brophy <Professor_jonny@...mail.com>,
 "Rob Herring (Arm)" <robh@...nel.org>,
 Jonathan Brophy <professorjonny98@...il.com>
Cc: Andriy Shevencho <andriy.shevchenko@...ux.intel.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, lee Jones <lee@...nel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
 Conor Dooley <conor+dt@...nel.org>, Pavel Machek <pavel@...nel.org>,
 Radoslav Tsvetkov <rtsvetkov@...dotech.eu>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v4 3/7] dt-bindings: leds: Add virtual LED group
 controller bindings

On 30/12/2025 09:32, Jonathan Brophy wrote:
>> My bot found errors running 'make dt_binding_check' on your patch:
> 
>> yamllint warnings/errors:
> 
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.example.dtb: pwm-led-controller (pwm->leds): 'led-pwm-blue', 'led-pwm-green', 'led-pwm-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', '^pinctrl-[0-9]+$'
> 
> 
> Thanks I have fixed this and re submitted a v5 patch series.
> 
> I have been testing on OpenWrt where the yaml and dts files are not validated and this slipped in.
> 


You must base and test on mainline, not OpenWRT. I understand above that
v5 wasn't tested either, so I won't be reviewing it.

Best regards,
Krzysztof