linux-kernel - Re: [PATCH 1/2] host1x: Make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFCAD4LVB5RF.3PI81T1E0OIID@bootlin.com>
Date: Wed, 31 Dec 2025 10:14:45 +0100
From: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>, "Akhil
 R" <akhilrajeev@...dia.com>, "Herbert Xu" <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, "Thierry Reding"
 <thierry.reding@...il.com>, "Jonathan Hunter" <jonathanh@...dia.com>,
 "Mikko Perttunen" <mperttunen@...dia.com>, "David Airlie"
 <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Sowjanya
 Komatineni" <skomatineni@...dia.com>, "Mauro Carvalho Chehab"
 <mchehab@...nel.org>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc: <linux-crypto@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
 <linux-media@...r.kernel.org>, <linux-staging@...ts.linux.dev>
Subject: Re: [PATCH 1/2] host1x: Make remove callback return void

Hello Uwe,

On Wed Dec 10, 2025 at 9:31 AM CET, Uwe Kleine-König wrote:
> The return value of struct device_driver::remove is ignored by the core
> (see device_remove() in drivers/base/dd.c). So it doesn't make sense to
> let the host1x remove callback return an int just to ignore it later.
>
> So make the callback return void. All current implementors return 0, so
> they are easily converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>

Tested-by: Luca Ceresoli <luca.ceresoli@...tlin.com> # tegra20 tegra-video
Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com