linux-kernel - Re: [PATCH v1 8/9] exfat: support multi-cluster for exfat_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49331fb0-9cfe-4ec9-a819-60ab62de15e7@163.com>
Date: Wed, 31 Dec 2025 09:51:30 +0800
From: Chi Zhiling <chizhiling@....com>
To: "Yuezhang.Mo@...y.com" <Yuezhang.Mo@...y.com>
Cc: "brauner@...nel.org" <brauner@...nel.org>,
 "chizhiling@...inos.cn" <chizhiling@...inos.cn>, "jack@...e.cz"
 <jack@...e.cz>, "linkinjeon@...nel.org" <linkinjeon@...nel.org>,
 "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "sj1557.seo@...sung.com" <sj1557.seo@...sung.com>,
 "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
 "willy@...radead.org" <willy@...radead.org>
Subject: Re: [PATCH v1 8/9] exfat: support multi-cluster for exfat_map_cluster

On 12/30/25 17:06, Yuezhang.Mo@...y.com wrote:
>> @@ -293,12 +298,14 @@ static int exfat_get_block(struct inode *inode, sector_t iblock,
>>
>>   	if (cluster == EXFAT_EOF_CLUSTER)
>>   		goto done;
>> +	if (WARN_ON_ONCE(!count))
>> +		count = 1;
> 
> The count is 0 only if cluster is EXFAT_EOF_CLUSTER.
> So this warning never occur, right? If yes, please remove it.

Yes, it's never 0 unless something goes wrong :)

I will remove it in v2.