linux-kernel - Re: [PATCH v2 1/2] staging: media: tegra-video: move tegra210_csi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DFCGGVLHKG5A.LNU7Q3W7B9UL@bootlin.com>
Date: Wed, 31 Dec 2025 15:01:46 +0100
From: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
To: "Sun Jian" <sun.jian.kdev@...il.com>
Cc: <linux-staging@...ts.linux.dev>, <thierry.reding@...il.com>,
 <jonathanh@...dia.com>, <skomatineni@...dia.com>, <mchehab@...nel.org>,
 <linux-tegra@...r.kernel.org>, <linux-media@...r.kernel.org>,
 <gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] staging: media: tegra-video: move
 tegra210_csi_soc declaration to csi.h

On Wed Dec 31, 2025 at 1:39 PM CET, Sun Jian wrote:
> Sparse warns that tegra210_csi_soc is not declared in tegra210.c.
> The symbol is referenced from csi.c, so it must remain global. Move the
> declaration to csi.h so users see it via the header and avoid extern
> declarations in .c files.
>
> SPARSE: drivers/staging/media/tegra-video/tegra210.c:1214:28: warning: symbol 'tegra210_csi_soc' was not declared. Should it be static?
>
> No functional change intended.
>
> Link: https://lore.kernel.org/linux-staging/DFCAOR6T9DPE.2MOL0K9O3HP1N@bootlin.com/T/
> Suggested-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> Signed-off-by: Sun Jian <sun.jian.kdev@...il.com>

Tested-by: Luca Ceresoli <luca.ceresoli@...tlin.com> # build tested
Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com