linux-kernel - Re: [PATCH] drm/bridge: synopsys: dw-dp: return when attach bridge fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aVU1Vh_gLf4uEsg0@osama>
Date: Wed, 31 Dec 2025 15:38:14 +0100
From: Osama Abdelkader <osama.abdelkader@...il.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: Andy Yan <andy.yan@...k-chips.com>,
	Andrzej Hajda <andrzej.hajda@...el.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Robert Foss <rfoss@...nel.org>,
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
	Jonas Karlman <jonas@...boo.se>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: synopsys: dw-dp: return when attach bridge
 fail

On Wed, Dec 31, 2025 at 03:09:51PM +0100, Luca Ceresoli wrote:
> On Fri Dec 26, 2025 at 11:32 PM CET, Osama Abdelkader wrote:
> > When drm_bridge_attach() fails, the function should return an error
> > instead of continuing execution.
> >
> > Signed-off-by: Osama Abdelkader <osama.abdelkader@...il.com>
> 
> Looks like a bugfix, should it have a 'Fixes:' tag and 'Cc: stable@...'?
> See https://docs.kernel.org/process/submitting-patches.html
> 
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> > @@ -2062,8 +2062,10 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder,
> >  	}
> >
> >  	ret = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
> > -	if (ret)
> > +	if (ret) {
> >  		dev_err_probe(dev, ret, "Failed to attach bridge\n");
> > +		return ERR_PTR(ret);
> > +	}
> >
> >  	dw_dp_init_hw(dp);
> >
> 
> It could be more concise, without adding braces:
> 
> 	if (ret)
> 		return ERR_PTR(dev_err_probe(dev, ret, "Failed to attach bridge\n"));
> 
> Luca
> 
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Thanks, v2 is on the way.

Best regards,
Osama